Skip to content

K2GO-583 fix(maps): an overlapping region says so, not "No internet connection" - #807

Merged
luisguzman-adfa merged 2 commits into
mainfrom
fix/K2GO-583-maps-overlap-message
Nov 18, 2026
Merged

luisguzman-adfa merged 2 commits into
mainfrom
fix/K2GO-583-maps-overlap-message

Conversation

@luisguzman-adfa

Copy link
Copy Markdown
Collaborator

What changes

  • MapsRegionClient.estimate tells the box's overlap answer (409 "overlaps an existing region") apart from a failed request: isOverlap() -> EstimateListener.onOverlap(). The unused English friendlyError is removed.
  • FqrController: an overlap shows its own dialog with OK only. "No internet connection" with Retry stays for real network failures.
  • UI changes:
    • New string k2go_fqr_overlap: "This region overlaps a region you already downloaded." (translated in all locales).
    • Overlap dialog, before -> after: "Can't download this region / No internet connection - connect to download." + Retry + Not now -> "Can't download this region / This region overlaps a region you already downloaded." + OK.
    • Light and dark: the dialog is the existing BrandDialog (theme colors); checked in dark on device.

Why

  • On Wi-Fi, a region that overlaps a downloaded one said "No internet connection", and Retry could never work.

Steps to QA

  • Baseline (main): download a region, then draw an overlapping one. The app shows "No internet connection" + Retry.
  • Change: same steps show the overlap message + OK. With Wi-Fi and data off, a new region still shows "No internet connection" + Retry.

Verifications

  • OPPO CPH2557: both cases checked. Evidence in Jira K2GO-583.
  • assembleStandardDebug and testStandardDebugUnitTest pass (new MapsRegionClientTest).

Notes

…onnection"

The size check now tells a 409 overlap answer from a failed request. An overlap shows its own message with OK; Retry stays for real network failures.
@luisguzman-adfa luisguzman-adfa added ui change or edit to UI strings changes or updates on xml strings files labels Nov 18, 2026
… it by text only

A 409 from the box can also mean a busy lock, so only the overlap text selects the overlap message.
@luisguzman-adfa

Copy link
Copy Markdown
Collaborator Author

f76bc03: the overlap case now reuses the shared errorDialog, and isOverlap reads the overlap text only (a busy-lock 409 keeps Retry; test added). Light mode verified on device: the dialog reads well in light and dark.

@luisguzman-adfa
luisguzman-adfa merged commit 1304e0c into main Nov 18, 2026
4 checks passed
@luisguzman-adfa
luisguzman-adfa deleted the fix/K2GO-583-maps-overlap-message branch November 18, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

strings changes or updates on xml strings files ui change or edit to UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant