Repository navigation
K2GO-583 fix(maps): an overlapping region says so, not "No internet connection" - #807
Merged
Merged
Conversation
…onnection" The size check now tells a 409 overlap answer from a failed request. An overlap shows its own message with OK; Retry stays for real network failures.
… it by text only A 409 from the box can also mean a busy lock, so only the overlap text selects the overlap message.
Collaborator
Author
|
f76bc03: the overlap case now reuses the shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
MapsRegionClient.estimatetells the box's overlap answer (409 "overlaps an existing region") apart from a failed request:isOverlap()->EstimateListener.onOverlap(). The unused EnglishfriendlyErroris removed.FqrController: an overlap shows its own dialog with OK only. "No internet connection" with Retry stays for real network failures.k2go_fqr_overlap: "This region overlaps a region you already downloaded." (translated in all locales).Why
Steps to QA
Verifications
assembleStandardDebugandtestStandardDebugUnitTestpass (newMapsRegionClientTest).Notes