Repository navigation
K2GO-582 fix(maps): no crash when you leave the map during a region download - #806
Merged
Merged
Conversation
…ownload A queued poll update read the listener again after stopPolling() cleared it. The update now reads the listener on the main thread, when it runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
MapsRegionClient.deliverreads the download listener on the main thread, when the queued progress or pause update runs, and skips it afterstopPolling()or a finished job.Why
stopPolling()read the listener again after it was set to null (GlitchTip KNOWLEDGE-TO-GO-8).Steps to QA
NullPointerException ... MapsRegionClient.java:134.Verifications
assembleStandardDebugandtestStandardDebugUnitTestpass.Notes