Repository navigation
K2GO-572 chore(release): v1.2.0 final release, versionCode update - #803
Merged
Merged
Conversation
Restore the Play Console summary line, drop the extra versionCode check and the Play wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
build.gradle: versionNamev1.2.0, versionCode 1020099 (APK and Play code 10200990).play-release.yml): runs from main and tags the final commitv1.2.0after checking that the approved candidate (v1.2.0-rc.3) is the newest rc. It does not touch Google Play.check-releasealso refuses a versionCode that does not match versionName.Why
Steps to QA
v1.2.0-rc.3stops, because the rc commit saysv1.2.0-rc.3.final-taggivesv1.2.0andcheck-releasepasses; a wrong versionCode is refused.Verifications
## v1.2.0entry is unchanged.Notes
v1.2.0-rc.3. Sending the final build to Play Production is a later step.