Repository navigation
ADFA-7135, ADFA-7136: SQLite debugger extension and MCP server for debug builds #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidschachterADFA
wants to merge
79
commits into
stage
Choose a base branch
from
sqlite-debugger/ADFA-7135
base: stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
d89431e
ADFA-7082: Vendor sqlite-js 1.3.7 with our patches
davidschachterADFA ae04160
ADFA-7082: Build the sqlite-js AAR for apps in subprojects:sqlite-js
davidschachterADFA f766299
ADFA-7082: Release the sqlite-js AAR to sqlite-js-latest
davidschachterADFA 3372d3b
ADFA-7082: Build the sqlite-js AAR for arm64-v8a and armeabi-v7a only
davidschachterADFA 1391c4b
ADFA-7082: Run no stored code by default; test sqlite-js on pull requ…
davidschachterADFA e0f400a
ADFA-7082: Update sqlite-js-latest in place, out of latest-release se…
davidschachterADFA 362ad7f
ADFA-7082: Sort the QuickJS copyright lines the same on every machine
davidschachterADFA 2f3460f
ADFA-7082: Log stored functions that cannot be listed; guard the tag …
davidschachterADFA 401a052
ADFA-7082: Vendor the reviewed sqlite-js patches
davidschachterADFA 44a6e88
ADFA-7082: Put back both the assets and the tag if a release update f…
davidschachterADFA 3c93bda
ADFA-7082: Find js_functions in any case; sync the cancel test; doc c…
davidschachterADFA 0d1f9db
ADFA-7082: Let a re-run repair a release left without its assets
davidschachterADFA ac748be
ADFA-7082: Vendor sqlite-js main with our changes merged, one patch left
davidschachterADFA 8086fd1
ADFA-7082: Vendor the sqlite-js 1.4.1 release
davidschachterADFA 6957c71
ADFA-7082: Let a connection open, and its stored functions load, duri…
davidschachterADFA 763bb47
ADFA-7082: Patch two stack-bound crashes and two garbage cases
davidschachterADFA c084450
ADFA-7082: Let a re-run replace a release left as a draft
davidschachterADFA 7f8e40c
style: spotless reformat, no functional change
davidschachterADFA a113c80
ADFA-7082: End the result sets an interrupted call leaves open
davidschachterADFA 64269ea
ADFA-7082: Make ending result sets safe when it runs JavaScript, and …
davidschachterADFA 851ee17
ADFA-7082: Stop what ending result sets runs; count the interrupts db…
davidschachterADFA 8973b29
ADFA-7082: Answer the independent review of patches 0004 to 0007
davidschachterADFA db04941
ADFA-7082: Test a direct interrupt during db.exec with a result set kept
davidschachterADFA e538658
Merge branch 'stage' into feat/ADFA-7082-sqlite-js-aar
davidschachterADFA b8f7aa6
ADFA-7135: Define the interface between the SQLite debugger extension…
claude c603f89
ADFA-7136: Copy the MCP server from ShareYourApps, renamed
claude fab6cff
ADFA-7135 Add the sqlite-debugger module skeleton
claude 1b53c59
ADFA-7136: MCP server with the eight read-only database tools
claude acddbd2
ADFA-7135 Implement the SQLite debugger extension and its host tests
claude ff0312f
ADFA-7135 Add the JNI layer and NativeDebugEngine
claude 31dc721
style: spotless reformat of the SQLite debugger module, no functional…
claude 16a006f
ADFA-7135 Fix three review findings in the extension
claude f03521d
ADFA-7136: Document the SQLite debugger module
claude e21aae3
ADFA-7136: List sqlite-debugger among the modules without ABI flavors
claude 8dd5efb
ADFA-7136 Never let the debugger crash or miss the host app's early c…
claude c862c5c
ADFA-7135 Keep read-only server connections from holding locks
claude 05c2a2b
ADFA-7136 Bound query results and report truncation per cell
claude d309d28
ADFA-7136 Drop stale server connections and stop expanding SQL when idle
claude d1f0feb
ADFA-7136 Test the JNI query path
claude 7684331
ADFA-7136 Document the JNI test and the requery trace limit
claude 3a5cb53
ADFA-7082: Vendor the sqlite-js 1.4.2 release
davidschachterADFA 464e6e7
ADFA-7082: Test sqlite-js 1.4.2's result-set rule and patch 0002
davidschachterADFA 5b9b062
ADFA-7082: Keep a call's cancel for the finals its result sets run
davidschachterADFA 5b5cd20
ADFA-7082: Say what a late cancel does to a call's finals
davidschachterADFA 9d87b3e
ADFA-7135 Set the Kotlin JVM target on the compile tasks
davidschachterADFA 0ec489a
ADFA-7082: Read result sets as interrupted when the cancel lands whil…
davidschachterADFA 5fc4976
ADFA-7082: Address review of the sqlite-js cancel patches
davidschachterADFA 3e1830f
ADFA-7136 Bound the request head and refuse before reading the body; …
davidschachterADFA 7cf251b
ADFA-7135 Refuse the process-wide heap limit and temp directory PRAGM…
davidschachterADFA f785f96
ADFA-7135 Give server connections a 3 s busy timeout
davidschachterADFA dcd342e
ADFA-7135 Fail a query whose argument count differs from its paramete…
davidschachterADFA d90b7b4
ADFA-7136 List an open database once when the databases folder is rea…
davidschachterADFA 3527173
ADFA-7135 Run the sqlite-debugger host tests in CI
davidschachterADFA b15fa5d
ADFA-7082: Vendor the sqlite-js 1.4.3 release, with no patches
davidschachterADFA d6e0d1a
style: spotless rewrap of the cancelAll() javadoc, no functional change
davidschachterADFA 0c2e603
ADFA-7082: Answer the independent review of the 1.4.3 move
davidschachterADFA f46e68e
ADFA-7082: Record the phone run of the 1.4.3 build
davidschachterADFA e9e3f7d
ADFA-7135: Merge #2244 (sqlite-js 1.4.3) into the debugger stack
davidschachterADFA 5b54c33
ADFA-7135: Correct two README lines the CI and device work made false
davidschachterADFA 49c84c0
ADFA-7135 Refuse SQL that holds more than one statement
davidschachterADFA ff0bd0c
ADFA-7136 Say when a query ran out of time waiting for another tool call
davidschachterADFA 0da5af2
ADFA-7136 Start a tool call's time limit when the call begins
davidschachterADFA d097e5d
ADFA-7135 Let the query backstop's ROLLBACK past the server's authorizer
davidschachterADFA 0d40222
ADFA-7136 Say when get_schema cut a CREATE statement
davidschachterADFA 403746b
ADFA-7136 Say that functions the app adds to its own connections are …
davidschachterADFA 9c916ca
ADFA-7136 Name both limits that can leave get_schema entries out
davidschachterADFA 6468cff
ADFA-7136 Say that a full integrity_check fails on the app's index fu…
davidschachterADFA cee95ac
ADFA-7136 Give get_schema's paging advice an ORDER BY and the right unit
davidschachterADFA bc76c14
ADFA-7136 Say which app functions make quick_check and integrity_chec…
davidschachterADFA e1864d2
ADFA-7136 Advise ORDER BY type, name to page through sqlite_master
davidschachterADFA 299266e
ADFA-7135 Register consumer-rules.pro so an app's R8 keeps NativeBridge
davidschachterADFA 8acd4bd
ADFA-7135 Refuse a server connection to a path the app no longer has …
davidschachterADFA e6d9171
ADFA-7135 Bound a JSON-RPC batch by message count and reply size
davidschachterADFA bc94eaa
ADFA-7135 State the true bound on a batch's replies
davidschachterADFA 0defc3f
ADFA-7135 Document the batch limits in the README
davidschachterADFA 85fbbd9
ADFA-7135 Refuse a server connection when every app connection to the…
davidschachterADFA 9200772
ADFA-7135 Say the first row of a result can pass the 4 MiB cap
davidschachterADFA dcadfe1
ADFA-7135 Say a call that waited half its time limit says so
davidschachterADFA 82ba6e7
ADFA-7135: Merge stage (#2244 squash-merged as 5f3d76aad) into the st…
davidschachterADFA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Test sqlite-debugger | ||
|
|
||
| # The tests the Android build cannot run (ADFA-7135): the extension's C tests under AddressSanitizer, | ||
| # UBSan and ThreadSanitizer, and the JNI query test on a host JVM. See subprojects/sqlite-debugger/test.sh, | ||
| # which downloads the SQLite amalgamation itself and checks its hash. | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'subprojects/sqlite-debugger/**' | ||
| - 'subprojects/sqlite-js/upstream/libs/**' | ||
| - '.github/workflows/test-sqlite-debugger.yml' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
|
|
||
| test-sqlite-debugger: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Run the sqlite-debugger tests | ||
| run: subprojects/sqlite-debugger/test.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MINOR: this job runs only
test.sh, soDatabaseToolsTest,McpProtocolTestandEventDecoderTest(80 tests) never run in CI. That includes the Kotlin side of theevents.binrecord-layout check.debug.ymlruns only:plugin-api:testDebugUnitTest, and the jacoco/sonar chain keys offtestV8DebugUnitTest, which this flavorless module doesn't have. No workflow in #2260, #2261 or #2262 adds it either.The gap already hides a real failure:
McpProtocolTest.clientsThatTrickleOrNeverAuthenticateAreDroppedAndDoNotBlockTheRealOnefails locally in every full-suite run (see the comment onMcpHttp.kt), while CI is green.Suggested fix: a step in this job (or in
debug.yml, next to the plugin-api step) that runs./gradlew :subprojects:sqlite-debugger:testDebugUnitTest.