Fix issues where passwords with '%' would be swallowed by printf#11
Open
z4ce wants to merge 1 commit intoapnex:masterfrom
Open
Fix issues where passwords with '%' would be swallowed by printf#11z4ce wants to merge 1 commit intoapnex:masterfrom
z4ce wants to merge 1 commit intoapnex:masterfrom
Conversation
This fixes an issue where certain characters in passwords would be swallowed up by the printf statement and cause every run to print '[WARN]: AUTH-CHANGE' and make it impossible to actually download any specific file. Authored-by: Ian Zink <izink@pivotal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where certain characters (like % or \) in passwords would
be swallowed up by the printf statement and cause every run to
print
[WARN]: AUTH-CHANGEand make it impossible to actuallydownload any specific file.