Skip to content

Add p90 and p99 response time metrics #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itssimon merged 3 commits into from
Apr 22, 2026
Merged

Add p90 and p99 response time metrics #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efc22be
Add p90 and p99 response time metrics
itssimon Apr 22, 2026
b85247b
Fix
itssimon Apr 22, 2026
b9b5c11
Add migration
itssimon Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions skills/apitally-cli/references/commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ Fetch aggregated metrics for an app. Outputs NDJSON to stdout by default.
| `error_rate` | float | Ratio of errors to total requests |
| `response_time_p50` | integer | 50th percentile response time (ms) |
| `response_time_p75` | integer | 75th percentile response time (ms) |
| `response_time_p90` | integer | 90th percentile response time (ms) |
| `response_time_p95` | integer | 95th percentile response time (ms) |
| `response_time_p99` | integer | 99th percentile response time (ms) |

### Group-by fields

Expand Down
4 changes: 3 additions & 1 deletion skills/apitally-cli/references/duckdb_tables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ CREATE TABLE metrics (
error_rate DOUBLE,
response_time_p50 INTEGER, -- milliseconds
response_time_p75 INTEGER, -- milliseconds
response_time_p95 INTEGER -- milliseconds
response_time_p90 INTEGER, -- milliseconds
response_time_p95 INTEGER, -- milliseconds
response_time_p99 INTEGER -- milliseconds
);
```

Expand Down
5 changes: 2 additions & 3 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,8 @@ enum Command {

/// JSON array or comma-separated list of metric names to include
///
/// Available metrics: requests, requests_per_minute, bytes_received,
/// bytes_sent, client_errors, server_errors, error_rate,
/// response_time_p50, response_time_p75, response_time_p95.
/// Available metrics: requests, requests_per_minute, bytes_received, bytes_sent, client_errors, server_errors, error_rate,
/// response_time_p50, response_time_p75, response_time_p90, response_time_p95, response_time_p99.
#[arg(long)]
metrics: String,

Expand Down
8 changes: 6 additions & 2 deletions src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,12 @@ pub(crate) fn ensure_metrics_table(conn: &duckdb::Connection) -> Result<()> {
error_rate DOUBLE,
response_time_p50 INTEGER,
response_time_p75 INTEGER,
response_time_p95 INTEGER
)",
response_time_p90 INTEGER,
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
response_time_p95 INTEGER,
response_time_p99 INTEGER
);
ALTER TABLE metrics ADD COLUMN IF NOT EXISTS response_time_p90 INTEGER;
ALTER TABLE metrics ADD COLUMN IF NOT EXISTS response_time_p99 INTEGER;",
)?;
Ok(())
}
Expand Down
Loading