Skip to content

fix: log error message on socket only when there are no other handlers #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2025
Merged

fix: log error message on socket only when there are no other handlers #623

merged 4 commits into from
Nov 28, 2025

Conversation

@bliuchak
Copy link
Contributor

@bliuchak bliuchak commented Nov 28, 2025

Porting back few changes from #602 in order to decrease HTTPS implementation scope.

Context:

  • Dockerfile change allows to run specific test cases instead of whole test file
  • Small bug fix, where we might have lack of observability on socket error events

@bliuchak bliuchak added medium priority Medium priority issues to be done in a couple of sprints. t-core-services Issues with this label are in the ownership of the core services team. t-unblocking Issues with this label are in the ownership of the unblocking team. labels Nov 28, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Nov 28, 2025
@bliuchak bliuchak added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 28, 2025
jirimoravcik
jirimoravcik approved these changes Nov 28, 2025
View reviewed changes
bliuchak and others added 2 commits November 28, 2025 15:30
@bliuchak @jirimoravcik
Update test/README.md
d1a9c06 
Co-authored-by: Jiří Moravčík <jiri.moravcik@gmail.com>
@bliuchak @jirimoravcik
Update test/README.md
d272a92 
Co-authored-by: Jiří Moravčík <jiri.moravcik@gmail.com>
@bliuchak bliuchak merged commit a8344fb into master Nov 28, 2025
7 of 10 checks passed
@bliuchak bliuchak deleted the fix/docker branch November 28, 2025 14:37
@raethlo raethlo added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@tobice tobice Awaiting requested review from tobice

Assignees

@bliuchak bliuchak

Labels

adhoc Ad-hoc unplanned task added during the sprint. medium priority Medium priority issues to be done in a couple of sprints. t-core-services Issues with this label are in the ownership of the core services team. t-unblocking Issues with this label are in the ownership of the unblocking team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Milestone

128th sprint - Core Services team

Development

Successfully merging this pull request may close these issues.

3 participants

@bliuchak @jirimoravcik @raethlo