Repository navigation
Conversation
Mantisus
force-pushed
the
record-pacing-signal
branch
from
October 29, 2026 14:46
a501c95 to
5c4274a
Compare
Mantisus
marked this pull request as ready for review
October 29, 2026 14:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RequestManagerhas a new abstract method,record_pacing_signal(). The crawler reports HTTP 429 responses and robots.txtCrawl-delaydirectives through it as aRateLimitedSignalor aMinIntervalSignal, both exported fromcrawlee.request_loaders.RequestQueuerefuses signals,RequestManagerTandemforwards them to its manager, andThrottlingRequestManagerpaces the domain. The crawler no longer checks the request manager's type, so aThrottlingRequestManagerinside aRequestManagerTandemnow receives 429s and crawl-delays too. The upgrade guide covers the migration.ThrottlingRequestManager.record_domain_delay()andset_crawl_delay()are replaced byrecord_pacing_signal(), andis_throttled()andrecord_success()are removed.base_delayandmax_delaymust be positive.RequestThrottledErrorraised in the request handler reports the rate limit itself, so it starts the domain's backoff without a prior call. The request is deferred only if the request manager paces its domain, and is handled as an ordinary error otherwise.Crawl-delaythat the request manager doesn't pace are logged once per domain, and the warning at the start ofrun()aboutrespect_robots_txt_fileis removed.Issues
is_empty/is_finishedwithcheck_readiness()and add pacing signals toRequestManager#2296is_emptyandis_finishedwithcheck_readiness#2334✍️ Drafted by Claude Code