feat(utilities): add iterableToArray helper#643
Closed
MrkMrk00 wants to merge 1 commit into
Closed
Conversation
Copilot stopped reviewing on behalf of
MrkMrk00 due to an error
May 27, 2026 11:38
github-actions
Bot
added
t-infra
MrkMrk00
force-pushed
the
feat/add-iterable-collect-helpers
branch
from
522e8b2 to
08f0974
Compare
MrkMrk00
force-pushed
the
feat/add-iterable-collect-helpers
branch
from
08f0974 to
e44b81d
Compare
B4nan
reviewed
May 27, 2026
Comment on lines
+34
to
+41
| async function asyncIterableToArray<T>(iterable: AsyncIterable<T>): Promise<T[]> { | ||
| const out: T[] = []; | ||
| for await (const item of iterable) { | ||
| out.push(item); | ||
| } | ||
|
|
||
| return out; | ||
| } |
Member
There was a problem hiding this comment.
this is the same as Array.fromAsync(), no?
Author
There was a problem hiding this comment.
:O Did not know about that one. This was my use case mainly, closing the PR. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new utility used to collect items from an iterable (or an async iterable) into an array.
Inspiration :) https://www.php.net/manual/en/function.iterator-to-array.php