fix: Handle exceptions in pre-reboot event listeners via return_exceptions#843
Merged
fix: Handle exceptions in pre-reboot event listeners via return_exceptions#843
return_exceptions#843Conversation
…ptions` Use `return_exceptions=True` in `asyncio.gather` during Actor reboot so that a failing listener does not prevent other listeners from persisting state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 86.40% 86.64% +0.23%
==========================================
Files 48 48
Lines 2906 2920 +14
==========================================
+ Hits 2511 2530 +19
+ Misses 395 390 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Mar 27, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Could you please add a test to confirm it behaves as expected
github-actions
bot
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return_exceptions=Truetoasyncio.gatherinActor.reboot()so a single failing listener no longer prevents others from persisting stateself.log.exceptionTest plan
🤖 Generated with Claude Code