refactor: Reduce API calls required to watch status during ActorClient.call#528
Closed
Pijukatel wants to merge 1 commit into
Closed
refactor: Reduce API calls required to watch status during ActorClient.call#528Pijukatel wants to merge 1 commit into
ActorClient.call#528Pijukatel wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
t-tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ResponseWatcherprotocol.response_watcherarguments towait_for_finishmethods.wait_for_finishuses an optionalresponse_watchercallable each time it processes the API response.Previously,
StatusWatcherwas periodically callingRunClient.getto get the status and status message of another Actor run. SinceActorClient.callis already periodically callingRunClient.getthroughRunClient.wait_for_finish, there is no need forStatusWatcherto do the API calls again; it just needs to re-use the responses of already available inRunClient.wait_for_finish. It can do so, by passing theresponse_watcherargument towait_for_finish.