Repository navigation
fix: align key iteration timeout with key listing - #1181
Merged
Merged
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
vdusek
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mediumHTTP timeout foriterate_keys()aslist_keys()in both sync and async clients. This applies to every paginated key request; callers can still pass an explicit timeout.Fixes #1173.
Verification
uv run --extra httpx2 pytest tests/unit/test_client_pagination.py -k 'kvs_iterate_keys_uses_list_keys_default_timeout' -q -o addopts='' --tb=short-> 4 expected failures (the page calls usedlong).uv run --extra httpx2 pytest tests/unit/test_client_pagination.py -q -o addopts='' --tb=short-> 756 passed.uv run --extra httpx2 --extra brotli poe unit-tests-> 2412 passed, 1 skipped (upstream generator incompatibility on Python 3.15).uv run --extra httpx2 poe check-docstrings,uv run --extra httpx2 ty check src/apify_client/_resource_clients/key_value_store.py tests/unit/test_client_pagination.py,uv run --extra httpx2 ruff check src/apify_client/_resource_clients/key_value_store.py tests/unit/test_client_pagination.py,uv run --extra httpx2 ruff format --check src/apify_client/_resource_clients/key_value_store.py tests/unit/test_client_pagination.py,git diff --check-> passed.AI assistance was used for implementation and tests; the change and verification were reviewed locally.