Skip to content

Add wait_for_finish to RunClient.get and BuildClient.get #1176

Description

@vdusek

RunClient.get and BuildClient.get take only timeout (run.py#L62-L76, build.py#L38-L52). The API's waitForFinish query parameter (up to 60 s server-side) is reachable only through wait_for_finish(), which loops until the job is terminal, or through ActorClient.build(wait_for_finish=...) at creation time.

The JS client accepts get({ waitForFinish }) on both (run.ts#L116-L125, build.ts#L71-L80) and extends the request timeout to cover the wait.

Expected behavior

get(*, wait_for_finish: timedelta | None = None, timeout=...) on RunClient, BuildClient and their async variants, sending waitForFinish in seconds and making sure the request timeout is at least the wait.

✍️ Drafted by Claude Code

Activity

  1. added
    enhancementNew feature or request.
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Oct 30, 2026
  2. added theissue type on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    t-toolingIssues with this label are in the ownership of the tooling team.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions