Skip to content

test: sort push source files by name before comparing - #1526

Merged
DaveHanns merged 1 commit into
masterfrom
test/push-sort-source-files-by-name
Oct 30, 2026
Merged

DaveHanns merged 1 commit into
masterfrom
test/push-sort-source-files-by-name

Conversation

@DaveHanns

Copy link
Copy Markdown
Contributor

The push API tests compare the version's sourceFiles with the locally collected list using .sort() without a comparator. On arrays of objects that sort is a no-op, so the assertions depend on the API and the local file listing returning files in the same order. That isn't guaranteed: "should work with actorId" failed once on #1504 with src/main.js and test/main.test.js swapped, then passed on re-run.

This sorts both sides by name in the three sourceFiles assertions in test/api/commands/push.test.ts.

🤖 Generated with Claude Code

@DaveHanns DaveHanns self-assigned this Oct 30, 2026
@DaveHanns
DaveHanns marked this pull request as ready for review October 30, 2026 00:02
@DaveHanns
DaveHanns requested a review from l2ysho as a code owner October 30, 2026 00:02
@DaveHanns
DaveHanns removed the request for review from l2ysho October 30, 2026 00:02
@DaveHanns DaveHanns added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 30, 2026
@apify-service-account apify-service-account added tested Temporary label used only programatically for some analytics. t-builders Issues owned by the Builders team. labels Oct 30, 2026

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Apify Factory auto approved ✅ — not a single eyebrow raised

Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.

Approval locked to 8ce7c7c21 · workflow run

@DaveHanns
DaveHanns merged commit 5afd1ba into master Oct 30, 2026
31 of 34 checks passed
@DaveHanns
DaveHanns deleted the test/push-sort-source-files-by-name branch October 30, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-builders Issues owned by the Builders team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants