feat: require Node.js 22 or newer - #1403
Draft
l2ysho wants to merge 1 commit into
Draft
Conversation
Node 20 reached end of life on 2026-04-30 and the dependency tree already excluded it: chalk@6 declares engines >=22, so `engines: ">=20"` was a promise the install could not keep. README and the installation docs have said 22+ for a while — this makes the manifest agree. Raise engines.node to >=22, drop the ^20.19.0 arm from devEngines, and remove Node 20 from the Local Tests matrix, which is what is currently failing on master. devEngines keeps the stricter >=22.12.0 floor that the build tooling needs. That is the contributor requirement; engines.node is the support claim made to users, and it tracks the Node major line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
l2ysho
force-pushed
the
claude/node20-support-removal-e57cdc
branch
from
September 8, 2026 19:47
17696e7 to
2644f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 reached EOL on 2026-04-30, and the dependency tree already excluded it —
chalk@6declaresengines: ">=22".engines: ">=20"was a promise the install could not keep. This is what the Node 20 legs ofLocal Testshave been failing on.Changes
engines.node:>=20→>=22devEngines.runtime.node: drop the^20.19.0arm, leaving>=22.12.0Local Testsmatrix:[20, 22, 24]→[22, 24]No source or docs changes needed.
SUPPORTED_NODEJS_VERSIONreadspkg.engines.node(src/lib/consts.ts:69), so the runtime guard and all user-facing messages follow automatically. README and the installation docs already said 22+.Why
>=22and not a patch-level floorThe strictest transitive runtime constraints are
which@7(^22.22.2 || ...) and@inquirer/core(^22.13.0), so no single patch version is "the" true floor for long — it moves with every dependency bump.engines.nodeis also enforced by a hard exit here (processVersionCheck,src/entrypoints/_shared.ts:58), not just an npm warning, so an over-strict floor blocks users who would otherwise be fine. A transitive engine mismatch is only a warning.devEngineskeeps the stricter>=22.12.0that the build tooling needs. That is the contributor requirement;engines.nodeis the support claim made to users, and it tracks the Node major line — the same one the CI matrix and base images track.Checked
Local Tests (…, 22)contexts — no…, 20)context is left permanently pendingprocessVersionCheckearly-returns forinstallMethod === 'bundle'pnpm run lint && format && buildpass.test:localhas 8 pre-existing failures inrun.test.ts("input tests") that reproduce identically on unmodifiedmaster— unrelated to this changeFollow-ups
src/commands/run.ts:193,204andsrc/entrypoints/_shared.ts:60interpolate the raw semver range into prose ("install Node.js >=22 (or higher)"). Sibling call sites already useminVersion(...). Pre-existing; not touched here🤖 Generated with Claude Code