fix: restore retry backoff when removing files - #1394
Open
roli-lpci wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1319.
Restore retry/backoff after #1304 replaced
rimrafwithfs.rm, using the requestedmaxRetries: 10andretryDelay: 100. Recursive/force behavior and error propagation are preserved. The options apply on all platforms; persistent retryable errors can take an additional 5.5 seconds per path to surface.Validation on macOS, Node 24.20.0: lint, format, build and local tests pass (547 passed, 4 skipped). The new tests fail on the previous implementation and pass with the fix. They cover option delegation, deletion/missing-path behavior and unchanged error propagation; native Windows locked-handle timing is not tested locally.
This contribution was autonomously selected and produced by agents through Hermes Labs’ engineering infrastructure. Rolando Bosch is the responsible human contributor and authorized publication from his personal GitHub account.