-
Notifications
You must be signed in to change notification settings - Fork 52
feat: support uv-managed Python Actors in apify create #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vdusek
wants to merge
5
commits into
master
Choose a base branch
from
feat/create-uv-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2672976
feat: support uv-managed Python Actors in apify create
vdusek 271c128
Merge remote-tracking branch 'origin/master' into feat/create-uv-support
vdusek f306d4c
address feedback
vdusek 12545be
Merge branch 'master' into feat/create-uv-support
vdusek 0f1d439
ci: gate the Python Support matrix behind a single required check
vdusek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { mkdir, rm, writeFile } from 'node:fs/promises'; | ||
| import { join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| import { getInstallCommandSuggestion } from '../../../../src/lib/hooks/runtimes/utils.js'; | ||
| import { cwdCache } from '../../../../src/lib/hooks/useCwdProject.js'; | ||
|
|
||
| const testDir = join(fileURLToPath(import.meta.url), '..', '..', '..', '..', 'tmp', 'install-command-suggestion-test'); | ||
|
|
||
| async function createFileIn(baseDir: string, relativePath: string, content = '') { | ||
| await mkdir(join(baseDir, ...relativePath.split('/').slice(0, -1)), { recursive: true }); | ||
| await writeFile(join(baseDir, relativePath), content); | ||
| } | ||
|
|
||
| describe('getInstallCommandSuggestion', () => { | ||
| beforeEach(async () => { | ||
| await rm(testDir, { recursive: true, force: true }); | ||
| await mkdir(testDir, { recursive: true }); | ||
| cwdCache.clear(); | ||
| }); | ||
|
|
||
| afterAll(async () => { | ||
| await rm(testDir, { recursive: true, force: true }); | ||
| }); | ||
|
|
||
| it('suggests "uv sync" for a uv-managed Python project', async () => { | ||
| await createFileIn(testDir, 'my_package/__init__.py'); | ||
| await createFileIn(testDir, 'my_package/__main__.py', 'print("hello")'); | ||
| await createFileIn(testDir, 'uv.lock', ''); | ||
|
|
||
| expect(await getInstallCommandSuggestion(testDir)).toBe('uv sync'); | ||
| }); | ||
|
|
||
| it('suggests pip install for a Python project without uv.lock', async () => { | ||
| await createFileIn(testDir, 'my_package/__init__.py'); | ||
| await createFileIn(testDir, 'my_package/__main__.py', 'print("hello")'); | ||
|
|
||
| expect(await getInstallCommandSuggestion(testDir)).toBe('python -m pip install -r requirements.txt'); | ||
| }); | ||
|
|
||
| it('suggests npm install for a JavaScript project without a lockfile', async () => { | ||
| await createFileIn(testDir, 'package.json', '{"name": "test", "scripts": {"start": "node index.js"}}'); | ||
|
|
||
| expect(await getInstallCommandSuggestion(testDir)).toBe('npm install'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.