feat: enhance MongoDB index checker with detailed sharding guidelines and common patterns#25
Open
mfori wants to merge 2 commits into
Open
feat: enhance MongoDB index checker with detailed sharding guidelines and common patterns#25mfori wants to merge 2 commits into
mfori wants to merge 2 commits into
Conversation
… and common patterns
mtrunkat
approved these changes
May 29, 2026
mvolfik
reviewed
May 29, 2026
Member
mvolfik
left a comment
mvolfik
left a comment
There was a problem hiding this comment.
i have no idea how to review this, nothing here seems factually wrong, don't know what else is expected from a prompt review
Member
Author
I think that's enough and we will see and can modify it later. You're on review mainly to be aware of this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are false positives in evaluation of sharding rules, for example here: https://github.com/apify/apify-core/pull/28206#pullrequestreview-4372775926
This should hopefully perform better.
Note: waiting for https://github.com/apify/apify-core/pull/28238