Skip to content

chore(api7): add max_lifetime and Vault config to dp_manager and developer_portal#273

Merged
nic-6443 merged 1 commit intomainfrom
feat/sync-helm-chart-with-e2e
Mar 31, 2026
Merged

chore(api7): add max_lifetime and Vault config to dp_manager and developer_portal#273
nic-6443 merged 1 commit intomainfrom
feat/sync-helm-chart-with-e2e

Conversation

@jarvis9443
Copy link
Copy Markdown
Contributor

@jarvis9443 jarvis9443 commented Mar 31, 2026

Summary

Add max_lifetime and Vault database credential configuration to dp_manager_configuration and developer_portal_configuration database sections, aligning them with the existing dashboard_configuration.

This is the companion PR to api7/api7ee-3-control-plane#2520, which syncs the e2e chart with this customer chart. Together, both PRs eliminate the accumulated drift between the two charts.

Changes

values.yaml

  • dp_manager_configuration.database: Add # max_lifetime: 60s (commented) and Vault integration config block (commented)
  • developer_portal_configuration.database: Add # max_lifetime: 60s (commented) and Vault integration config block (commented)
  • Fix minor double-space typo in dp_manager basic_auth comment

Rationale

All API7 components (dashboard, dp_manager, developer_portal) share the same Go database layer and support the same configuration options. Having Vault and max_lifetime only in some components' values creates confusion for users. This change ensures consistency.

After both PRs merge

The only remaining differences between e2e and customer charts will be:

  • chart version / appVersion / image tags
  • File Server component (e2e only, will be synced via separate PR)

Test exemption

No tests needed — only adds commented-out configuration options to values.yaml with no behavioral change.

Summary by CodeRabbit

  • Documentation
    • Added configuration templates for database connection management and vault credential integration options in Helm deployment charts.
    • Improved Prometheus authentication documentation formatting.

…loper_portal

Add commented-out max_lifetime and Vault database credential configuration
to dp_manager_configuration and developer_portal_configuration database
sections, aligning with the existing dashboard_configuration.

This ensures all API7 components have consistent database configuration
options including Vault integration support.

Also fix minor double-space typo in dp_manager basic_auth comment.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 31, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8be4f9f3-3ae0-4682-a137-118b2e5f4d36

📥 Commits

Reviewing files that changed from the base of the PR and between 59db2e3 and d670c87.

📒 Files selected for processing (1)
  • charts/api7/values.yaml

📝 Walkthrough

Walkthrough

This change adds commented-out configuration examples to the API7 Helm chart values file. New sections document database max_lifetime options and vault credential management blocks with TLS controls across multiple service configurations, along with a minor comment alignment adjustment for Prometheus basic authentication.

Changes

Cohort / File(s) Summary
Helm Chart Configuration Documentation
charts/api7/values.yaml
Added commented-out max_lifetime: 60s option and comprehensive vault configuration blocks (including connection settings, credential cache TTL, auth methods, database mount/role, and TLS controls) to dashboard_configuration.database, dp_manager_configuration.database, and developer_portal_configuration.database. Adjusted comment alignment for prometheus.basic_auth documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 New configs hop into the chart,
Vault whispers secrets, TLS plays its part,
Commented options, a guide so bright,
No breaking changes—all feels right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding max_lifetime and Vault config to dp_manager and developer_portal in the Helm chart values file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sync-helm-chart-with-e2e

Comment @coderabbitai help to get the list of available commands and usage tips.

@nic-6443 nic-6443 merged commit 8620ffa into main Mar 31, 2026
3 of 5 checks passed
@nic-6443 nic-6443 deleted the feat/sync-helm-chart-with-e2e branch March 31, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants