Conversation
…loper_portal Add commented-out max_lifetime and Vault database credential configuration to dp_manager_configuration and developer_portal_configuration database sections, aligning with the existing dashboard_configuration. This ensures all API7 components have consistent database configuration options including Vault integration support. Also fix minor double-space typo in dp_manager basic_auth comment.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds commented-out configuration examples to the API7 Helm chart values file. New sections document database Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Add
max_lifetimeand Vault database credential configuration todp_manager_configurationanddeveloper_portal_configurationdatabase sections, aligning them with the existingdashboard_configuration.This is the companion PR to api7/api7ee-3-control-plane#2520, which syncs the e2e chart with this customer chart. Together, both PRs eliminate the accumulated drift between the two charts.
Changes
values.yaml
# max_lifetime: 60s(commented) and Vault integration config block (commented)# max_lifetime: 60s(commented) and Vault integration config block (commented)basic_authcommentRationale
All API7 components (dashboard, dp_manager, developer_portal) share the same Go database layer and support the same configuration options. Having Vault and max_lifetime only in some components' values creates confusion for users. This change ensures consistency.
After both PRs merge
The only remaining differences between e2e and customer charts will be:
chart version/appVersion/ image tagsTest exemption
No tests needed — only adds commented-out configuration options to values.yaml with no behavioral change.
Summary by CodeRabbit