fix(filter): Do not nest array while generating default schema#7832
Open
VincentLanglet wants to merge 2 commits intoapi-platform:4.2from
Open
fix(filter): Do not nest array while generating default schema#7832VincentLanglet wants to merge 2 commits intoapi-platform:4.2from
VincentLanglet wants to merge 2 commits intoapi-platform:4.2from
Conversation
VincentLanglet
force-pushed
the
openApiFilterTrait
branch
from
51b88e4 to
64eb25a
Compare
VincentLanglet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't fully understand the fix in #7658, especially the part doing
unconditionally @soyuka.
When I bump my ApiPlatform, I end up with generated schema of
for something like
brand[]=foo, and I don't see it's correct.To me if the schema is already an array one, we shouldn't wrap it inside another array one.
Am I wrong ?