Make apex-common accessable over shared namespace 2nd gen packages

sfdx-source/apex-common/main/classes/fflib_Application.cls

@@ -29,26 +29,32 @@
  * of the Apex Enterprise Patterns, Service, Unit Of Work, Selector and Domain.
  *   See the sample applications Application.cls file for an example
  **/
+@NamespaceAccessible
 public virtual class fflib_Application
 {
 	/**
 	 * Class implements a Unit of Work factory
 	 **/
+	@NamespaceAccessible
 	public virtual class UnitOfWorkFactory implements fflib_IUnitOfWorkFactory
 	{
+		@NamespaceAccessible
 		protected List<SObjectType> m_objectTypes;
+		@NamespaceAccessible
 		protected fflib_ISObjectUnitOfWork m_mockUow;
 
 		/**
 		 * Constructs a Unit Of Work factory
 		 **/
+		@NamespaceAccessible
 		public UnitOfWorkFactory() { }
 
 		/**
 		 * Constructs a Unit Of Work factory
 		 *
 		 * @param objectTypes List of SObjectTypes in dependency order
 		 **/
+		@NamespaceAccessible
 		public UnitOfWorkFactory(List<SObjectType> objectTypes)
 		{
 			m_objectTypes = objectTypes.clone();
@@ -59,6 +65,7 @@ public virtual class fflib_Application
 		 *   SObjectType list provided in the constructor, returns a Mock implementation
 		 *   if set via the setMock method
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_ISObjectUnitOfWork newInstance()
 		{
 			// Mock?
@@ -72,6 +79,7 @@ public virtual class fflib_Application
 		 *   SObjectType list provided in the constructor, returns a Mock implementation
 		 *   if set via the setMock method
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_ISObjectUnitOfWork newInstance(fflib_SObjectUnitOfWork.IDML dml)
 		{
 			// Mock?
@@ -88,6 +96,7 @@ public virtual class fflib_Application
 		 * @remark If mock is set, the list of SObjectType in the mock could be different
 		 *         than the list of SObjectType specified in this method call
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_ISObjectUnitOfWork newInstance(List<SObjectType> objectTypes)
 		{
 			// Mock?
@@ -104,6 +113,7 @@ public virtual class fflib_Application
 		 * @remark If mock is set, the list of SObjectType in the mock could be different
 		 *         than the list of SObjectType specified in this method call
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_ISObjectUnitOfWork newInstance(List<SObjectType> objectTypes, fflib_SObjectUnitOfWork.IDML dml)
 		{
 			// Mock?
@@ -113,6 +123,7 @@ public virtual class fflib_Application
 		}
 
 		@TestVisible
+		@NamespaceAccessible
 		protected virtual void setMock(fflib_ISObjectUnitOfWork mockUow)
 		{
 			m_mockUow = mockUow;
@@ -122,15 +133,19 @@ public virtual class fflib_Application
 	/**
 	 * Simple Service Factory implementation
 	 **/
+	@NamespaceAccessible
 	public virtual class ServiceFactory implements fflib_IServiceFactory
 	{
+		@NamespaceAccessible
 		protected Map<Type, Type> m_serviceInterfaceTypeByServiceImplType;
 
+		@NamespaceAccessible
 		protected Map<Type, Object> m_serviceInterfaceTypeByMockService;
 
 		/**
 		 * Constructs a simple Service Factory
 		 **/
+		@NamespaceAccessible
 		public ServiceFactory() { }
 
 		/**
@@ -141,6 +156,7 @@ public virtual class fflib_Application
 		 *
 		 * @param serviceInterfaceTypeByServiceImplType Map of interfaces to classes
 		 **/
+		@NamespaceAccessible
 		public ServiceFactory(Map<Type, Type> serviceInterfaceTypeByServiceImplType)
 		{
 			m_serviceInterfaceTypeByServiceImplType = serviceInterfaceTypeByServiceImplType;
@@ -155,6 +171,7 @@ public virtual class fflib_Application
 		 * @param serviceInterfaceType Apex interface type
 		 * @exception Is thrown if there is no registered Apex class for the interface type
 		 **/
+		@NamespaceAccessible
 		public virtual Object newInstance(Type serviceInterfaceType)
 		{
 			// Mock implementation?
@@ -169,6 +186,7 @@ public virtual class fflib_Application
 		}
 
 		@TestVisible
+		@NamespaceAccessible
 		protected virtual void setMock(Type serviceInterfaceType, Object serviceImpl)
 		{
 			m_serviceInterfaceTypeByMockService.put(serviceInterfaceType, serviceImpl);
@@ -178,14 +196,18 @@ public virtual class fflib_Application
 	/**
 	 * Class implements a Selector class factory
 	 **/
+	@NamespaceAccessible
 	public virtual class SelectorFactory implements fflib_ISelectorFactory
 	{
+		@NamespaceAccessible
 		protected Map<SObjectType, Type> m_sObjectBySelectorType;
+		@NamespaceAccessible
 		protected Map<SObjectType, fflib_ISObjectSelector> m_sObjectByMockSelector;
 
 		/**
 		 * Constructs a simple Selector Factory
 		 **/
+		@NamespaceAccessible
 		public SelectorFactory() { }
 
 		/**
@@ -195,6 +217,7 @@ public virtual class fflib_Application
 		 *
 		 * @param sObjectBySelectorType Map of SObjectType's to Selector Apex Classes
 		 **/
+		@NamespaceAccessible
 		public SelectorFactory(Map<SObjectType, Type> sObjectBySelectorType)
 		{
 			m_sObjectBySelectorType = sObjectBySelectorType;
@@ -207,6 +230,7 @@ public virtual class fflib_Application
 		 *
 		 * @param sObjectType An SObjectType token, e.g. Account.SObjectType
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_ISObjectSelector newInstance(SObjectType sObjectType)
 		{
 			// Mock implementation?
@@ -230,6 +254,7 @@ public virtual class fflib_Application
 		 * @param recordIds The SObject record Ids, must be all the same SObjectType
 		 * @exception Is thrown if the record Ids are not all the same or the SObjectType is not registered
 		 **/
+		@NamespaceAccessible
 		public virtual List<SObject> selectById(Set<Id> recordIds)
 		{
 			// No point creating an empty Domain class, nor can we determine the SObjectType anyway
@@ -258,6 +283,7 @@ public virtual class fflib_Application
 		 * @param relatedRecords used to extract the related record Ids, e.g. Opportunity records
 		 * @param relationshipField field in the passed records that contains the relationship records to query, e.g. Opportunity.AccountId
 		 **/
+		@NamespaceAccessible
 		public virtual List<SObject> selectByRelationship(List<SObject> relatedRecords, SObjectField relationshipField)
 		{
 			Set<Id> relatedIds = new Set<Id>();
@@ -271,6 +297,7 @@ public virtual class fflib_Application
 		}
 
 		@TestVisible
+		@NamespaceAccessible
 		protected virtual void setMock(fflib_ISObjectSelector selectorInstance)
 		{
 			m_sObjectByMockSelector.put(selectorInstance.sObjectType(), selectorInstance);
@@ -280,17 +307,22 @@ public virtual class fflib_Application
 	/**
 	 * Class implements a Domain class factory
 	 **/
+	@NamespaceAccessible
 	public virtual class DomainFactory implements fflib_IDomainFactory
 	{
+		@NamespaceAccessible
 		protected fflib_Application.SelectorFactory m_selectorFactory;
 
+		@NamespaceAccessible
 		protected Map<Object, Type> constructorTypeByObject;
 
+		@NamespaceAccessible
 		protected Map<Object, fflib_IDomain> mockDomainByObject;
 
         /**
 		 * Constructs a Domain factory
 		 **/
+		@NamespaceAccessible
 		public DomainFactory() { }
 
 		/**
@@ -302,6 +334,7 @@ public virtual class fflib_Application
 		 * @param selectorFactory , e.g. Application.Selector
 		 * @param constructorTypeByObject Map of Domain classes by ObjectType
 		 **/
+		@NamespaceAccessible
 		public DomainFactory(fflib_Application.SelectorFactory selectorFactory,
 			Map<Object, Type> constructorTypeByObject)
 		{
@@ -319,6 +352,7 @@ public virtual class fflib_Application
 		 * @param selectorFactory, e.g. Application.Selector
 		 * @param sObjectByDomainConstructorType Map of Apex classes by SObjectType
 		 **/
+		@NamespaceAccessible
 		public DomainFactory(fflib_Application.SelectorFactory selectorFactory,
 			Map<SObjectType, Type> sObjectByDomainConstructorType)
 		{
@@ -335,6 +369,7 @@ public virtual class fflib_Application
 		 * @param recordIds A list of Id's of the same type
 		 * @exception Throws an exception via the Selector Factory if the Ids are not all of the same SObjectType
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_IDomain newInstance(Set<Id> recordIds)
 		{
 			return newInstance(m_selectorFactory.selectById(recordIds));
@@ -349,6 +384,7 @@ public virtual class fflib_Application
 		 * @exception Throws an exception if the SObjectType cannot be determined from the list
 		 *              or the constructor for Domain class was not registered for the SObjectType
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_IDomain newInstance(List<SObject> records)
 		{
 			SObjectType domainSObjectType = records.getSObjectType();
@@ -358,6 +394,7 @@ public virtual class fflib_Application
 			return newInstance((List<Object>) records, (Object) domainSObjectType);
 		}
 
+		@NamespaceAccessible
 		public virtual fflib_IDomain newInstance(List<Object> objects, Object objectType)
 		{
 			// Mock implementation?
@@ -401,6 +438,7 @@ public virtual class fflib_Application
 		 * @remark Will support List<SObject> but all records in the list will be assumed to be of
 		 *         the type specified in sObjectType
 		 **/
+		@NamespaceAccessible
 		public virtual fflib_IDomain newInstance(List<SObject> records, SObjectType domainSObjectType)
 		{
 			if(domainSObjectType==null)
@@ -413,17 +451,20 @@ public virtual class fflib_Application
 		}
 
 		@TestVisible
+		@NamespaceAccessible
 		protected virtual void setMock(fflib_ISObjectDomain mockDomain)
 		{
 			mockDomainByObject.put((Object) mockDomain.sObjectType(), (fflib_IDomain) mockDomain);
 		}
 
 		@TestVisible
+		@NamespaceAccessible
 		protected virtual void setMock(fflib_IDomain mockDomain)
 		{
 			mockDomainByObject.put(mockDomain.getType(), mockDomain);
 		}
 
+		@NamespaceAccessible
 		protected virtual Map<Object, Type> getConstructorTypeByObject(Map<SObjectType, Type> constructorTypeBySObjectType)
 		{
 			Map<Object, Type> result = new Map<Object, Type>();
@@ -438,10 +479,12 @@ public virtual class fflib_Application
 		}
 	}
 
+	@NamespaceAccessible
 	public class ApplicationException extends Exception { }			
 
 	/**
 	 * Exception representing a developer coding error, not intended for end user eyes
 	 **/
+	@NamespaceAccessible
 	public class DeveloperException extends Exception { } 
 }

sfdx-source/apex-common/main/classes/fflib_IDomain.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_IDomain
 {
 	Object getType();

sfdx-source/apex-common/main/classes/fflib_IDomainConstructor.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_IDomainConstructor
 {
 	fflib_IDomain construct(List<Object> objects);

sfdx-source/apex-common/main/classes/fflib_IDomainFactory.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_IDomainFactory
 {
 	fflib_IDomain newInstance(Set<Id> recordIds);

sfdx-source/apex-common/main/classes/fflib_IObjects.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_IObjects extends fflib_IDomain
 {
 	/**

sfdx-source/apex-common/main/classes/fflib_ISObjectDomain.cls

@@ -23,7 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
-
+@NamespaceAccessible
 public interface fflib_ISObjectDomain extends fflib_IDomain
 {
     /**

sfdx-source/apex-common/main/classes/fflib_ISObjectSelector.cls

@@ -23,7 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
-
+@NamespaceAccessible
 public interface fflib_ISObjectSelector
 {
 	/**

sfdx-source/apex-common/main/classes/fflib_ISObjectUnitOfWork.cls

@@ -27,6 +27,7 @@
 /**
  * @see fflib_SObjectUnitOfWork
  **/
+@NamespaceAccessible
 public interface fflib_ISObjectUnitOfWork
 {
     /**

sfdx-source/apex-common/main/classes/fflib_ISObjects.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_ISObjects extends fflib_IObjects
 {
 	/**

sfdx-source/apex-common/main/classes/fflib_ISelectorFactory.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_ISelectorFactory
 {
 	fflib_ISObjectSelector newInstance(SObjectType sObjectType);

sfdx-source/apex-common/main/classes/fflib_IServiceFactory.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_IServiceFactory
 {
 	Object newInstance(Type serviceInterfaceType);

sfdx-source/apex-common/main/classes/fflib_IUnitOfWorkFactory.cls

@@ -23,6 +23,7 @@
  *  OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
+@NamespaceAccessible
 public interface fflib_IUnitOfWorkFactory
 {
 	fflib_ISObjectUnitOfWork newInstance();