Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The external-populator PVC handoff uses the host client cache to read the selected host Node. PR9's chart grants the vcluster service account only
nodes/get, so the cache cannot list/watch Nodes and the restore handoff remains blocked withnodes is forbidden.Change
nodesget,list, andwatchunder the existing fake-PV PVC handoff condition.The existing condition remains unchanged, so this permission is added only when PVC sync is enabled, PV sync is disabled, and host Node sync is disabled.
Validation
helm unittest chart -f tests/clusterrole_test.yaml— 45/45 passedhelm lint chart— passedhelm templatewith fake-PV PVC sync — renderednodes: get/list/watchgit diff --check— passedThis is a child fix on PR9's development branch. The completed Oracle R8 environment was not modified or replayed.