Skip to content

ZOOKEEPER-4892: Keep self vote in sync in FastLeaderElection TLA receiveVotes #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arup-chauhan wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −8
Open

ZOOKEEPER-4892: Keep self vote in sync in FastLeaderElection TLA receiveVotes #2355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions zookeeper-specifications/system-spec/zk-3.7/FastLeaderElection.tla
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,22 @@ RvClear(i) == receiveVotes' = [receiveVotes EXCEPT ![i] = [v \in Server |-> [v
RvPut(i, id, mvote, mround, mstate) == receiveVotes' = CASE receiveVotes[i][id].round < mround -> [receiveVotes EXCEPT ![i][id].vote = mvote,
![i][id].round = mround,
![i][id].state = mstate,
![i][id].version = 1]
![i][id].version = 1,
![i][i].vote = currentVote'[i],
![i][i].round = mround,
![i][i].state = LOOKING,
![i][i].version = @ + 1]
[] receiveVotes[i][id].round = mround -> [receiveVotes EXCEPT ![i][id].vote = mvote,
![i][id].state = mstate,
![i][id].version = @ + 1]
[] receiveVotes[i][id].round > mround -> receiveVotes
![i][id].version = @ + 1,
![i][i].vote = currentVote'[i],
![i][i].round = mround,
![i][i].state = LOOKING,
![i][i].version = @ + 1]
[] receiveVotes[i][id].round > mround -> [receiveVotes EXCEPT ![i][i].vote = currentVote'[i],
![i][i].round = mround,
![i][i].state = LOOKING,
![i][i].version = @ + 1]

Put(i, id, rcvset, mvote, mround, mstate) == CASE rcvset[id].round < mround -> [rcvset EXCEPT ![id].vote = mvote,
![id].round = mround,
Expand All @@ -203,11 +214,16 @@ Put(i, id, rcvset, mvote, mround, mstate) == CASE rcvset[id].round < mround -> [
![id].version = @ + 1]
[] rcvset[id].round > mround -> rcvset

RvClearAndPut(i, id, vote, round) == receiveVotes' = LET oneVote == [vote |-> vote,
round |-> round,
state |-> LOOKING,
version |-> 1]
IN [receiveVotes EXCEPT ![i] = [v \in Server |-> IF v = id THEN oneVote
RvClearAndPut(i, id, vote, round) == receiveVotes' = LET oneVote == [vote |-> vote,
round |-> round,
state |-> LOOKING,
version |-> 1]
selfVote == [vote |-> currentVote'[i],
round |-> round,
state |-> LOOKING,
version |-> 1]
IN [receiveVotes EXCEPT ![i] = [v \in Server |-> IF v = i THEN selfVote
ELSE IF v = id THEN oneVote
ELSE [vote |-> InitialVote,
round |-> 0,
state |-> LOOKING,
Expand Down