ZOOKEEPER-5013: Initialize MainThread members#2347
Open
seekskyworld wants to merge 1 commit intoapache:masterfrom
Open
ZOOKEEPER-5013: Initialize MainThread members#2347seekskyworld wants to merge 1 commit intoapache:masterfrom
seekskyworld wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Please don't create test classes for test classes, otherwise you should write a test class for your test class which tests another class. When you're ready, you should write another test class which tests the test class that tests the previous test class, and so on... |
Contributor
|
Patches should be opened against the master branch at the first place. |
anmolnar
requested changes
Jan 20, 2026
Contributor
anmolnar
left a comment
There was a problem hiding this comment.
Please see my comments above.
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
eec805d to
5fed23b
Compare
Contributor
Author
|
@anmolnar Thanks for the feedback. I removed the test-class-for-test-class and kept only the MainThread field initialization. I |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.apache.org/jira/browse/ZOOKEEPER-5013
Summary:
Motivation:
Validation: