[ZEPPELIN-6686] Align E2E coverage with Angular component targets - #5445
Open
voidmatcha wants to merge 1 commit into
Open
[ZEPPELIN-6686] Align E2E coverage with Angular component targets#5445voidmatcha wants to merge 1 commit into
voidmatcha wants to merge 1 commit into
Conversation
voidmatcha
force-pushed
the
fix/e2e-coverage-targets
branch
from
August 30, 2026 01:51
fbb88f0 to
dd2d7d8
Compare
jongyoul
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
CoverageReporterignored the configuredtransformtargets and scanned the Angular source tree again withscandirectory. This kept structural components in the report denominator and allowedPAGESto drift from the reported targets.This PR uses
cfg.transformas the reporter denominator.getCoverageTransformPaths()discoverssrc/app/**/*.component.ts, removes four explicit structural components, and sorts the result. A Vitest spec requiresPAGESto match the discovered targets.Node.js 22 provides
fs.globSync, so this PR removesscandirectory. It also includes package-level reporter specs in the shell Vitest, TypeScript and ESLint paths.The metric covers the current Angular-hosted routes. A later route cutover must define how React-owned routes are counted.
This PR does not change runtime behavior, add E2E coverage, or introduce a coverage threshold. The current source tree contains 57 Angular components and four exclusions, resulting in 53 targets.
The affected
AGENTS.mdfiles document the new rules. The package guidance also reflects the TestBed setup merged through ZEPPELIN-6637.What type of PR is it?
Bug Fix
Todos
transformas the reporter denominatorPAGESand exclusion alignmentscandirectoryAGENTS.mdfilesWhat is the Jira issue?
ZEPPELIN-6686
How should this be tested?
cd zeppelin-web-angular npm run test:shell npx tsc -p src/tsconfig.spec.json --noEmit npx eslint \ e2e/reporter.coverage.ts \ e2e/reporter.coverage.config.ts \ e2e/utils.ts \ test/reporter.coverage.spec.ts \ vitest.shell.config.mts \ eslint.config.jsResults:
Screenshots (if appropriate)
N/A
Questions:
AGENTS.mdfiles are updated.