Repository navigation
[Fix][DLight] Decline matmul schedules with unsupported consumer chains - #20774
Open
Edwardssss wants to merge 1 commit into
Open
Edwardssss wants to merge 1 commit into
Edwardssss wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20615
Problem
A fused conv2d -> bias -> ReLU -> output-padding function reaches the GPU Matmul rule, but the output-expanding consumer cannot be inlined into its cache-write stage. Consumer inlining is best effort; remaining consumers are an unsupported scheduling case, not an internal invariant violation.
Previously,
auto_inline_consumer_chainasserted that all consumers had been inlined. This abortedApplyDefaultSchedulebefore subsequent rules could run. An additional producer's explicitcompute_inlinecould also raise aScheduleErrorinstead of declining the schedule.Changes
auto_inline_consumer_chainindicating whether all consumers were inlined.s_tir.ScheduleErroraround the additional producer's explicitcompute_inline; do not wrap the entire rule or suppress programming errors.Nonefrom both generic Matmul and MetalMatmul when the helper fails, preserving DLight's existing rule-dispatch contract.