Repository navigation
[REFACTOR] Keep attribute contracts with their owning interfaces - #20772
Merged
Merged
Conversation
Name operator attribute headers for their key declarations and type colocated keys using their existing value contracts. Preserve erased-map and callback compatibility boundaries, and expose optional typed Target backend configuration without changing serialized runtime configuration. Use tensor type alignment directly when lowering allocations and emitting CUDA storage declarations. Keep the Hexagon device constructor in the runtime namespace.
tlopex
approved these changes
Oct 17, 2026
Remove template disambiguators from dependent GetAttr calls whose value types are inferred from their attribute keys.
tqchen
added a commit
that referenced
this pull request
Oct 17, 2026
) Name operator attribute headers for their key declarations and type colocated keys using their existing value contracts. Preserve erased-map and callback compatibility boundaries, and expose optional typed Target backend configuration without changing serialized runtime configuration. Use tensor type alignment directly when lowering allocations and emitting CUDA storage declarations. Keep the Hexagon device constructor in the runtime namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name operator attribute headers for their key declarations and type colocated keys using their existing value contracts. Preserve erased-map and callback compatibility boundaries, and expose optional typed Target backend configuration without changing serialized runtime configuration.
Use tensor type alignment directly when lowering allocations and emitting CUDA storage declarations. Keep the Hexagon device constructor in the runtime namespace.