Fix PytestUnknownMarkWarning: Unknown pytest.mark.adreno_clml#19602
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml file to register new pytest markers for Adreno-specific tests. The reviewer pointed out that the list of markers is incomplete and suggested adding several missing markers, such as adreno_vulkan and adreno_opencl, to prevent PytestUnknownMarkWarning during test execution.
| markers = [ | ||
| "adreno_clml: Mark a test as using adreno_clml", | ||
| "adreno_opencl_vulkan: Mark a test as using adreno_opencl_vulkan", | ||
| ] |
There was a problem hiding this comment.
The registration of markers is incomplete. Based on the features defined in tests/python/relax/backend/adreno/utils.py, there are other Adreno-specific features that will trigger PytestUnknownMarkWarning when used. Specifically, adreno_vulkan, adreno_opencl, and adreno_opencl_real should also be registered to ensure all Adreno test markers are recognized by pytest.
markers = [
"adreno_clml: Mark a test as using adreno_clml",
"adreno_opencl_vulkan: Mark a test as using adreno_opencl_vulkan",
"adreno_vulkan: Mark a test as using adreno_vulkan",
"adreno_opencl: Mark a test as using adreno_opencl",
"adreno_opencl_real: Mark a test as using adreno_opencl_real",
]
tlopex
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Could you please register all Adreno Feature marks, not only the two that appeared in the warning?
tests/python/relax/backend/adreno/utils.py defines five pytest marks through tvm.testing.Feature:
adreno_clmladreno_opencl_vulkanadreno_vulkanadreno_opencladreno_opencl_real
With the current change, adreno_vulkan, adreno_opencl, and adreno_opencl_real can still trigger PytestUnknownMarkWarning when those tests are collected. Please add those three markers to pyproject.toml as well.
|
Thanks to @tlopex 😄 |
Hi Commiters,
This PR fixs
PytestUnknownMarkWarning: Unknown pytest.mark.adreno_clml - is this a typo?