fix: skip dsymutil for static tvm_runtime on Apple platforms

[MasterJH5574]

dsymutil cannot process static libraries (.a files), causing the build to fail when building tvm_runtime as a static library for iOS. Only run dsymutil on tvm_runtime when building the shared library variant.

[gemini-code-assist]

Summary of Changes

Hello @MasterJH5574, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific build issue encountered on Apple platforms when compiling tvm_runtime as a static library. By introducing a conditional check in the CMake configuration, the dsymutil tool, which is incompatible with static libraries, is now correctly bypassed in this scenario, ensuring successful compilation.

Highlights

• Build Fix for Apple Platforms: Resolved a build failure on Apple platforms that occurred when tvm_runtime was configured as a static library. The dsymutil tool, which is incompatible with static libraries, was being incorrectly applied, leading to compilation errors.
• Conditional dsymutil Application: Modified the CMakeLists.txt to conditionally apply dsymutil to tvm_runtime. It will now only run when tvm_runtime is built as a shared library, by checking if(NOT BUILD_STATIC_RUNTIME).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• CMakeLists.txt
  • Added a conditional if(NOT BUILD_STATIC_RUNTIME) block around the tvm_ffi_add_apple_dsymutil(tvm_runtime) call. This prevents dsymutil from being executed when tvm_runtime is built as a static library.

Activity

• The pull request was created by MasterJH5574.
• No human activity (comments, reviews) has occurred yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a build failure on Apple platforms when tvm_runtime is configured as a static library. The dsymutil tool fails on static archives, and this change correctly adds a condition to only execute dsymutil for tvm_runtime when it's being built as a shared library. The fix is straightforward, correct, and aligns with the project's build logic. No issues were found.