Skip to content

Conversation

@junrushao
Copy link
Member

@junrushao junrushao commented Dec 24, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical dependency update, specifically bumping the TVM-FFI library to its v0.1.6 version. This ensures the project leverages the latest enhancements, bug fixes, and performance improvements provided by the updated library, maintaining compatibility and stability with its external components.

Highlights

  • TVM-FFI Submodule Update: The tvm-ffi git submodule has been updated from commit ae346ec92a3c386f1376064ae086aae72947c329 to 438f6439148b059d424ce2cc2a348736923f6948, aligning with the stated update to version v0.1.6.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@junrushao junrushao requested a review from tqchen December 24, 2025 18:13
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tvm-ffi submodule to a new commit, 438f6439148b059d424ce2cc2a348736923f6948, which corresponds to version v0.1.6. This is a dependency update. The change itself is correct, but the pull request lacks a description. For dependency updates, it is a best practice to include a summary of changes or a link to the changelog in the pull request description. This provides crucial context for reviewers to assess the impact of the update. Assuming this new version has been tested and is compatible, the change is acceptable.

@junrushao junrushao marked this pull request as draft December 24, 2025 23:48
@junrushao junrushao changed the title Update TVM-FFI to v0.1.6 Update TVM-FFI to v0.1.7 Dec 24, 2025
@junrushao junrushao changed the title Update TVM-FFI to v0.1.7 Integrate with tvm-ffi-stubgen Dec 24, 2025
@junrushao junrushao force-pushed the junrus/2025-12-24/update-tvm-ffi branch from 4fca387 to 4e3aec1 Compare December 25, 2025 01:12
@junrushao
Copy link
Member Author

#18597

@junrushao
Copy link
Member Author

>>> tvm-ffi-stubgen python/tvm/ \
  --imports tvm_ffi \
  --dlls ./build/libtvm.so
[Skipped] Invalid name in global function: SourceMapAdd
[Skipped] Invalid name in global function: __tvm_set_device
[Skipped] Invalid name in global function: cache_flush_cpu_non_first_arg
[Skipped] Invalid name in global function: l2_cache_flush_cuda
[Failed] File "/home/dolores/Projects/tvm-dev/python/tvm/contrib/msc/core/ir/graph.py": Traceback (most recent call last):
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/cli.py", line 90, in __main__
    _stage_3(file, opt, ty_map, global_funcs)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/cli.py", line 227, in _stage_3
    obj_info = object_info_from_type_key(type_key)
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/lib_state.py", line 36, in object_info_from_type_key
    type_info = _lookup_or_register_type_info_from_type_key(str(type_key))
  File "python/tvm_ffi/cython/object.pxi", line 515, in tvm_ffi.core._lookup_or_register_type_info_from_type_key
  File "python/tvm_ffi/cython/object.pxi", line 429, in tvm_ffi.core._type_info_create_from_type_key
ValueError: Cannot find type key: msc.core.MSCTensor

[Failed] File "/home/dolores/Projects/tvm-dev/python/tvm/ir/type_relation.py": Traceback (most recent call last):
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/cli.py", line 90, in __main__
    _stage_3(file, opt, ty_map, global_funcs)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/cli.py", line 227, in _stage_3
    obj_info = object_info_from_type_key(type_key)
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/lib_state.py", line 36, in object_info_from_type_key
    type_info = _lookup_or_register_type_info_from_type_key(str(type_key))
  File "python/tvm_ffi/cython/object.pxi", line 515, in tvm_ffi.core._lookup_or_register_type_info_from_type_key
  File "python/tvm_ffi/cython/object.pxi", line 429, in tvm_ffi.core._type_info_create_from_type_key
ValueError: Cannot find type key: TypeCall

[Failed] File "/home/dolores/Projects/tvm-dev/python/tvm/runtime/profiling/__init__.py": Traceback (most recent call last):
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/cli.py", line 90, in __main__
    _stage_3(file, opt, ty_map, global_funcs)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/cli.py", line 227, in _stage_3
    obj_info = object_info_from_type_key(type_key)
  File "/home/dolores/Projects/tvm-dev/3rdparty/tvm-ffi/python/tvm_ffi/stub/lib_state.py", line 36, in object_info_from_type_key
    type_info = _lookup_or_register_type_info_from_type_key(str(type_key))
  File "python/tvm_ffi/cython/object.pxi", line 515, in tvm_ffi.core._lookup_or_register_type_info_from_type_key
  File "python/tvm_ffi/cython/object.pxi", line 429, in tvm_ffi.core._type_info_create_from_type_key
ValueError: Cannot find type key: runtime.profiling.PAPIMetricCollector

The three errors look quite reasonable. I didn't compile with USE_MSC or USE_PAPI, and TypeCall is indeed not defined

@junrushao junrushao force-pushed the junrus/2025-12-24/update-tvm-ffi branch from 4e3aec1 to bf7c1b9 Compare December 25, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant