[feat] Add overflow check for uint64_t/size_t in TypeTraits<Int>::CopyToAnyView

[nan2088]

Related discussion here #357
Adds runtime overflow detection when converting unsigned 64-bit integers (uint64_t or size_t) to int64_t in TVM FFI Any.

128-bit signed integers (if exists) are not considered.

[gemini-code-assist]

Summary of Changes

Hello @nan2088, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial runtime overflow detection mechanism within the TVM FFI's Any type conversion logic. It specifically targets conversions of large unsigned 64-bit integers (uint64_t or size_t) to int64_t, which previously could lead to silent data loss. By throwing an OverflowError when such a condition is met, the change ensures data integrity and forces developers to explicitly handle potential value truncations, making the system more robust and predictable.

Highlights

• Overflow Check for Unsigned Integers: Implemented a runtime overflow check for uint64_t and size_t when they are converted to int64_t within the TypeTraits<Int>::CopyToAnyView function in TVM FFI.
• Error Handling: Introduced an OverflowError exception that is thrown if an unsigned 64-bit integer value exceeds the maximum capacity of int64_t during conversion, preventing silent data truncation.
• Test Coverage: Added a new test case to test_any.cc to specifically verify that the OverflowError is correctly thrown when an uint64_t value larger than INT64_MAX is assigned to an Any object.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable overflow check when converting unsigned 64-bit integers to int64_t within the TVM FFI, preventing potential data corruption. The implementation in type_traits.h is clean, using if constexpr to ensure the check is only applied where necessary, with no performance impact on other types. The new test case in test_any.cc effectively validates this new safety feature. I have one minor suggestion for the test file to improve its portability.

[junrushao]

@nan2088 I updated your branch and fixed the C++ unittest. It should work now.

CC: @tqchen for review

[tqchen]

Need explicit comment.

// static_cast from int64_t to uint64_t will behave exactly like bit cast

[tqchen]

do the same for other places of the static cast

[tqchen]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces an important overflow check when converting large unsigned 64-bit integers to int64_t within the TVM FFI, preventing potential data corruption. The accompanying test case effectively validates this new check. The changes also include updating structural hashing functions to use int64_t for hash values for FFI consistency. My review focuses on ensuring type consistency in these hashing changes. I've found one area where a callback signature should be adjusted for better type safety and clarity.