Repository navigation
docs: clarify local test binaries vs pre-push Maven verification - #1109
Merged
Merged
Conversation
Directly built test binaries are the fast iteration path, but CI builds and tests through Maven, so they miss Maven's compile/link/package steps (e.g. a missing out-of-class constexpr definition links on macOS but fails under Linux/LTO). Document both entry points and require the Maven profile verification before committing or pushing.
The Required Checks section already mandates the clean full Maven suite; describe the profile commands as smoke checks instead of telling readers to omit clean.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1109 +/- ##
========================================
Coverage 66.89% 66.89%
========================================
Files 788 788
Lines 57630 57630
Branches 9310 9310
========================================
+ Hits 38551 38552 +1
Misses 17399 17399
+ Partials 1680 1679 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repository documents two ways to run tests — the Maven profiles in the root
CLAUDE.mdand the directly builtTsFile_Testbinary incpp/CLAUDE.md— without saying how they differ. Running only the binary is much faster but skips Maven's compile/link/package steps, so failures that only appear in the CI pipeline are missed. A recent example: aconstexprdata member without an out-of-class definition linked fine on macOS with the directly built binary but failed under Linux/LTO in CI.Change
Documentation only:
CLAUDE.md: new "Local Iteration vs. Pre-Push Verification" section — direct test binary /pytestfor fast iteration, Maven profile verification as the smoke check before pushing, and a pointer to the existing "Required Checks Before Pushing" section for the fullcleansuite and sanitizer runs.cpp/CLAUDE.mdandpython/CLAUDE.md: annotate their "Run tests" entries as the fast-iteration path and state that pushing requires the Maven entry point CI uses.No code, scripts or build configuration changed.
git diff --checkis clean.