Add unit tests for FilterValve, ProxyErrorReportValve and SemaphoreValve#976
Open
onkar717 wants to merge 1 commit intoapache:mainfrom
Open
Add unit tests for FilterValve, ProxyErrorReportValve and SemaphoreValve#976onkar717 wants to merge 1 commit intoapache:mainfrom
onkar717 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves test coverage by adding unit tests for several Valve
implementations that currently lack dedicated tests:
Motivation
While reviewing Tomcat valve implementations, these components were
identified as having little or no direct test coverage. Adding tests
helps improve reliability and prevents regressions during future
changes.
Changes
Added new test classes:
The tests cover:
Testing
All tests pass locally using:
Run all 3 new test classes
Run with coverage to verify coverage increase
No existing tests were modified.
Impact
No functional changes.
Test coverage improvement only.