Fix race condition in MemoryUserDatabase.save() by extending lock scope#1014
Open
sahvx655-wq wants to merge 1 commit into
Open
Fix race condition in MemoryUserDatabase.save() by extending lock scope#1014sahvx655-wq wants to merge 1 commit into
sahvx655-wq wants to merge 1 commit into
Conversation
sahvx655-wq
force-pushed
the
fix/memory-user-db-race-condition
branch
from
1182414 to
6c4b3e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a concurrency issue in MemoryUserDatabase.save() where file rename operations were performed after releasing the writeLock.
Under concurrent save requests, multiple threads could interfere with the same .new and .old files, leading to IOExceptions or inconsistent tomcat-users.xml state.
This change extends the writeLock scope to cover the complete file replacement workflow, ensuring the save operation remains atomic.
Changes
Hold writeLock until all rename operations complete
Move backup/rename logic inside the protected section
Add TestMemoryUserDatabaseConcurrency.java regression test