Update order of operation for request interceptor and serialization in gremlin-go#3358
Open
Update order of operation for request interceptor and serialization in gremlin-go#3358
Conversation
…cess like other GLVs
…y drain before close to prevent TCP RST errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go serializes request before passing to interceptors, which was a concern highlighted in .NET PR review and deviating from other GLVs. This PR mainly fixes that by changing order of operation, and passing in the raw request message to interceptors first, then serialize the request.
Slightly different design from .NET and python, as go DRC/client API did not expose the
serializersetting to users. Here by default, if interceptor does not perform serialization, then the unserializedrequest(nowRequestMessage) gets serialized by GraphBinary intobyte[]. If users wish to use their own serializer via interceptors, they should return eitherbyte[],io.Reader, or ahttp.Request, which are the types accepted by the http client library.Some minor fixes also tagging along here:
requeststruct toRequestMessage, as it can get confusing with an http.Request. Also exported the type for easier interceptor access, and is now consistent as this is public also in other GLVs.VOTE +1