Add Request Interceptors for Javascript#3337
Merged
Cole-Greer merged 3 commits intomasterfrom Mar 25, 2026
Merged
Conversation
Cole-Greer
force-pushed
the
js-interceptors
branch
from
1093638 to
13b2798
Compare
Contributor
|
VOTE +1 |
spmallette
reviewed
Mar 23, 2026
Contributor
|
VOTE +1 |
Cole-Greer
force-pushed
the
js-interceptors
branch
from
13b2798 to
b519312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds request interceptors for Javascript, modeled after the interceptors which have already been added to Python. There are 2 reference implementations of interceptors to provide both
basicandsigv4auth. Additionally the configuration of serializers has been refactored, with the oldmimeTypeconnection option removed in favour of direct use ofwriterandreader(consistent with other GLVs). The writer has additionally become optional to grant additional flexibility if users wish to run an interceptor on an un-serialized request body.My vote is VOTE +1