You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
THRIFT-5830: Add per-call transport support for netstd - #4000
THRIFT-5830: Add per-call transport support for netstd
Client: cpp,netstd
Add opt-in per-call transports for generated asynchronous clients, isolating HTTP and layered transport state while preserving existing shared-protocol constructors.
Preserve caller-configured HTTP timeouts and propagate the linked cancellation token through generated request and response operations. Add focused transport, lifecycle, concurrency, timeout, generator, and tutorial coverage.
Co-Authored-By: GitHub Copilot
Note: AI/OpenSpec artifacts are completely optional. Let me know if you want to keep these or have me remove them.
Remove unrelated third-party CLI workflow from this PR
.github/workflows/copilot-setup-steps.yml:36
This introduces a permanent third-party CLI installation workflow that is unrelated to the per-call transport change described by the PR. Because the workflow is triggered for every lib/netstd/** push and pull request but only prints the CLI version (it runs neither transport tests nor openspec validate), it adds recurring CI/network cost without validating this feature; move the OpenSpec agent/setup infrastructure to a separate PR or remove it here.
Dispose returned transport when wrapper construction fails
If constructing the buffered wrapper throws after the provider has returned its call-owned transport (for example, while reading a custom transport's Configuration), that transport is leaked. This method owns the returned transport and should dispose it on wrapper-construction failure, as the framed implementation does.
Avoid running Copilot setup on every netstd push and pull request
.github/workflows/copilot-setup-steps.yml:17
These triggers run a global npm installation on every future netstd push and pull request, but the job only prints the CLI version and does not validate the checked-in specs or source. That adds an unrelated external dependency and CI job to all netstd changes; keep this Copilot setup workflow dispatch-only, or turn it into actual OpenSpec validation in a separately scoped tooling change.
Client: cpp,netstd
Add opt-in per-call transports for generated asynchronous clients, isolating
HTTP and layered transport state while preserving existing shared-protocol
constructors.
Preserve caller-configured HTTP timeouts and propagate the linked cancellation
token through generated request and response operations. Add focused transport,
lifecycle, concurrency, timeout, generator, and tutorial coverage.
Co-Authored-By: GitHub Copilot
@Jens-G Note: AI/OpenSpec artifacts are completely optional. Let me know if you want to keep these or have me remove them.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build and general CIcmake, automake and build system changesc#Pull requests that update C# code Pull requests that update .NET codecompilergithub_actionsPull requests that update GitHub Actions code
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergeable
Bot
added
c#
THRIFT-5830: Add per-call transport support for netstd
Client: cpp,netstd
Add opt-in per-call transports for generated asynchronous clients, isolating HTTP and layered transport state while preserving existing shared-protocol constructors.
Preserve caller-configured HTTP timeouts and propagate the linked cancellation token through generated request and response operations. Add focused transport, lifecycle, concurrency, timeout, generator, and tutorial coverage.
Co-Authored-By: GitHub Copilot
Note: AI/OpenSpec artifacts are completely optional. Let me know if you want to keep these or have me remove them.
[skip ci]anywhere in the commit message to free up build resources.