Enable TLS hostname verification in TNonblockingSSLSocket#3396
Merged
Jens-G merged 1 commit intoapache:masterfrom Apr 14, 2026
Merged
Enable TLS hostname verification in TNonblockingSSLSocket#3396Jens-G merged 1 commit intoapache:masterfrom
Jens-G merged 1 commit intoapache:masterfrom
Conversation
Client: java Set EndpointIdentificationAlgorithm to HTTPS on the SSLEngine parameters in the TNonblockingSSLSocket constructor so that the server certificate CN/SAN is validated against the target hostname during the TLS handshake. This mirrors the behavior of TSSLTransportFactory.createClient() and aligns the async SSL client with the sync client. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EndpointIdentificationAlgorithmtoHTTPSon theSSLEngineparameters in theTNonblockingSSLSocketconstructor, so the server certificate CN/SAN is validated against the target hostname during the TLS handshake.TSSLTransportFactory.createClient(). Before this change, the async SSL client path (viaSSLEngine) did not set the endpoint identification algorithm, leaving the two client paths inconsistent. This was pointed out in #3390 (comment).Client: java
Test plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com