Skip to content

Added --server-type argument to Ruby cross-tests integration server#3308

Merged
Jens-G merged 1 commit intoapache:masterfrom
kpumuk:cross-test-server-type
Feb 19, 2026
Merged

Added --server-type argument to Ruby cross-tests integration server#3308
Jens-G merged 1 commit intoapache:masterfrom
kpumuk:cross-test-server-type

Conversation

@kpumuk
Copy link
Contributor

@kpumuk kpumuk commented Feb 13, 2026

While working on #3307, I wanted to test Nonblocking server with cross tests and notice that Ruby integration test server does not support server type selection. C++ adds --server-type argument, and Python accepts it as positional.

This change adds --server-type and allows to run cross tests with different server types.

Unsurprisingly, cross-tests passed for framed transport and failed for buffered: https://github.com/kpumuk/thrift/actions/runs/22001432085/job/63575905711 (which is not compatible with nonblocking server).

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable bot added the ruby label Feb 13, 2026
@Jens-G Jens-G merged commit 96d62dd into apache:master Feb 19, 2026
59 of 60 checks passed
@kpumuk kpumuk deleted the cross-test-server-type branch February 19, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments