Skip to content

fix(amber): return 404 for unavailable public workflow #9061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShawnGarello wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −0
Open

fix(amber): return 404 for unavailable public workflow #9061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e8427
test(amber): reproduce the 500 from retrievePublicWorkflow
ShawnGarello Oct 20, 2026
75da5e9
fix(amber): return 404 for unavailable public workflow
ShawnGarello Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,9 @@ class WorkflowResource extends LazyLogging {
.where(WORKFLOW.WID.eq(wid))
.and(WORKFLOW.IS_PUBLIC.isTrue)
.fetchOne()
if (workflow == null) {
throw new NotFoundException(s"Public workflow with id $wid not found")
}
// Name and description come from the public copy for the same reason as the content: a pin has
// to hold everything on show.
val publicCopy = WorkflowPublishService.publicCopyOf(workflow.into(classOf[Workflow]))
Expand Down
10 changes: 10 additions & 0 deletions ...r/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,16 @@ class WorkflowResourceSpec
assertThrows[ForbiddenException](workflowResource.makePublic(wid, sessionUser2))
}

"WorkflowResource.retrievePublicWorkflow" should "throw NotFoundException for a private workflow" in {
val wid = seedWorkflow(sessionUser1, "public-private-wf").workflow.getWid
assertThrows[NotFoundException](workflowResource.retrievePublicWorkflow(wid))
}

it should "throw NotFoundException for a wid that does not exist" in {
val wid = seedWorkflow(sessionUser1, "public-missing-wf").workflow.getWid
assertThrows[NotFoundException](workflowResource.retrievePublicWorkflow(wid + 100000))
}

"WorkflowResource.duplicateWorkflow" should "create a distinct copy owned by the user" in {
// duplicateWorkflow reassigns operator ids, so the content must have an operators array.
val wid = seedWorkflow(
Expand Down
Loading