Repository navigation
Conversation
The result store keeps one entry per operator, built from every result URI of the execution. An operator with two stored output ports, such as a terminal Split, got whichever port came last, so the row count the frontend paged by could be the other port's. The result updates read the first port, so the count now comes from the first port too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
Contributor
Author
|
@carloea2 could you take a look at this when you have a chance? Thanks! |
Contributor
Author
|
Moved into #9054, which now carries this fix together with reading the other output ports. Closing this one. |
Contributor
Automated Reviewer SuggestionsBased on the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The result store keeps one row count per operator and builds it from every stored result of the execution. A terminal operator with two outputs, such as Split, has both outputs stored, so the count of whichever port was read last replaced the other. The result panel shows the first output and pages it by that count, so its pager could stop early or run past the rows. The count now comes from the first output port, the one the result panel reads.
Any related issues, documentation, discussions?
Closes #9050
How was this PR tested?
A new case in
ExecutionResultServiceSpecstores 3 rows on an operator's first port and 8 on its second, and checks that the operator is reported with 3. It fails on main with 8. The rest of the spec passes.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code