chore(sql): remove the superseded manual update scripts 01-22 - #7703
Open
aglinxinyuan wants to merge 2 commits into
Open
chore(sql): remove the superseded manual update scripts 01-22#7703aglinxinyuan wants to merge 2 commits into
aglinxinyuan wants to merge 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7703 +/- ##
============================================
- Coverage 90.93% 90.93% -0.01%
+ Complexity 4450 4449 -1
============================================
Files 1174 1174
Lines 47139 47139
Branches 5284 5284
============================================
- Hits 42867 42865 -2
- Misses 2579 2580 +1
- Partials 1693 1694 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
✅ No material benchmark regressions detected🟢 2 better · 🔴 0 worse · ⚪ 13 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,506.57,200,128000,395,0.241,24955.74,33851.36,33851.36
1,100,10,64,20,2489.55,2000,1280000,803,0.490,123571.15,146240.82,146240.82
2,1000,10,64,20,21999.26,20000,12800000,909,0.555,1098299.95,1140380.65,1140380.65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
sql/updates/01.sqlthrough22.sql, which sit outside the applied migration chain — nothing in the repository can execute them. Pure deletion, no behaviour change: −989 lines.The chain is defined solely by
sql/changelog.xml, whose live changesets are 23-37. Its only mention of a lower number issql/updates/1.sql, inside an<!-- example changeSet -->comment — and no such file exists, since the real ones are zero-padded. Neither bootstrap path needs the deleted files:Every runner was checked against that:
sql/docker-compose.yml--changeLogFile=changelog.xml; theupdates/*.sqlloop only sed-normalizes files into/tmp, and its glob still matches 23-37bin/local-dev/main.shparse_changelog_changesetsskips XML comments and applies only referenced changesetsbin/single-node/docker-compose.ymlsql/into/docker-entrypoint-initdb.d; the postgres entrypoint does not recurse intoupdates/.github/workflows/automatic-email-notif-on-ddl-change.yml--diff-filter=A(added only), so deletions are inertAny related issues, documentation, discussions?
Closes #7702
How was this PR tested?
Existing tests only — this PR removes files that no runner executes.
From the repo root:
bash bin/local-dev/tests/test_local_dev_sh.sh— 114 passed, including the two that guard this exact contract:changelog parser: 15 changesets, commented example skippedchangelog: every referenced sql/updates file existsIts 3 failures (
worktree pointer,listen_pid_for_port,install cmd: java via brew) are pre-existing on this Windows machine — confirmed identical with the deletion stashed, and caused by the absence oflsof/ss/brewrather than by this change.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)