fix(test): stabilize flaky ReconfigurationIntegrationSpec pause race#5915
Open
Ma77Ball wants to merge 4 commits into
Open
fix(test): stabilize flaky ReconfigurationIntegrationSpec pause race#5915Ma77Ball wants to merge 4 commits into
Ma77Ball wants to merge 4 commits into
Conversation
… a pause is generated leading to a failed ci
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 435 | 0.265 | 22,605/32,977/32,977 us | 🔴 +19.5% / 🔴 +111.7% |
| 🟢 | bs=100 sw=10 sl=64 | 954 | 0.582 | 106,934/119,979/119,979 us | 🟢 -8.5% / 🔴 +9.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,090 | 0.666 | 924,444/952,529/952,529 us | ⚪ within ±5% / 🟢 -12.0% |
Baseline details
Latest main 7a9730b from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 435 tuples/sec | 476 tuples/sec | 758.88 tuples/sec | -8.6% | -42.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.265 MB/s | 0.291 MB/s | 0.463 MB/s | -8.9% | -42.8% |
| bs=10 sw=10 sl=64 | p50 | 22,605 us | 18,915 us | 12,965 us | +19.5% | +74.4% |
| bs=10 sw=10 sl=64 | p95 | 32,977 us | 29,881 us | 15,578 us | +10.4% | +111.7% |
| bs=10 sw=10 sl=64 | p99 | 32,977 us | 29,881 us | 18,378 us | +10.4% | +79.4% |
| bs=100 sw=10 sl=64 | throughput | 954 tuples/sec | 956 tuples/sec | 968.9 tuples/sec | -0.2% | -1.5% |
| bs=100 sw=10 sl=64 | MB/s | 0.582 MB/s | 0.584 MB/s | 0.591 MB/s | -0.3% | -1.6% |
| bs=100 sw=10 sl=64 | p50 | 106,934 us | 102,685 us | 102,767 us | +4.1% | +4.1% |
| bs=100 sw=10 sl=64 | p95 | 119,979 us | 131,160 us | 109,629 us | -8.5% | +9.4% |
| bs=100 sw=10 sl=64 | p99 | 119,979 us | 131,160 us | 118,129 us | -8.5% | +1.6% |
| bs=1000 sw=10 sl=64 | throughput | 1,090 tuples/sec | 1,092 tuples/sec | 997.01 tuples/sec | -0.2% | +9.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.666 MB/s | 0.667 MB/s | 0.609 MB/s | -0.1% | +9.4% |
| bs=1000 sw=10 sl=64 | p50 | 924,444 us | 918,924 us | 1,009,306 us | +0.6% | -8.4% |
| bs=1000 sw=10 sl=64 | p95 | 952,529 us | 958,708 us | 1,051,088 us | -0.6% | -9.4% |
| bs=1000 sw=10 sl=64 | p99 | 952,529 us | 958,708 us | 1,082,535 us | -0.6% | -12.0% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,460.20,200,128000,435,0.265,22605.42,32977.19,32977.19
1,100,10,64,20,2096.28,2000,1280000,954,0.582,106933.52,119978.70,119978.70
2,1000,10,64,20,18340.58,20000,12800000,1090,0.666,924444.10,952529.41,952529.41
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Author
|
/request-review @aglinxinyuan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
ReconfigurationIntegrationSpecfromsmallCsvScanOpDesc(100 rows) tomediumCsvScanOpDesc(100k rows), so the workflow is still running whenpauseWorkflowlands.PauseHandler.pauseWorkflowemitted COMPLETED instead of PAUSED andTestUtils.shouldReconfigures 10spausedReachedawait timed out.ReconfigurationSpecandPauseSpec, which already usemediumCsvScanOpDescfor the same pause/reconfigure/resume flow.Any related issues, documentation, discussions?
Closes: #5913
How was this PR tested?
sbt "WorkflowExecutionService/Test/compile"compiles cleanly with the change.amber-integrationstack (Python UDF + Postgres/MinIO/Lakekeeper) that CI provisions; could not run locally. Reviewer: run theamber-integrationjob (orsbt "WorkflowExecutionService/testOnly *ReconfigurationIntegrationSpec"in that environment) and confirm all 3 tests pass across repeated runs.workflow pausedlog line for every test run (the flaky run showed fewer pauses than test runs).Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF