feat(udf): enable Python UDF UI parameters end to end#5912
Open
carloea2 wants to merge 12 commits into
Open
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5912 +/- ##
============================================
+ Coverage 54.37% 54.49% +0.12%
- Complexity 2857 2861 +4
============================================
Files 1107 1107
Lines 42767 42885 +118
Branches 4599 4599
============================================
+ Hits 23253 23369 +116
- Misses 18160 18161 +1
- Partials 1354 1355 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
808dcd6 to
46ccb80
Compare
Contributor
✅ No material benchmark regressions detected🟢 5 better · 🔴 0 worse · ⚪ 10 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,467.35,200,128000,428,0.261,22335.23,34925.27,34925.27
1,100,10,64,20,2143.96,2000,1280000,933,0.569,106872.89,122979.31,122979.31
2,1000,10,64,20,18508.33,20000,12800000,1081,0.660,921358.97,982624.32,982624.32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR wires the existing Python UDF UI parameter support into the end-to-end execution path.
It changes:
uiParametersproperty to Python UDF, dual-input Python UDF, and Python UDF source operators.PythonUdfUiParameterInjector.inject(...)before creating Python physical operators.uiParameterswith the existing UI-parameter editor.UiParameterexamples to Python UDF templates.Any related issues, documentation, discussions?
Part of the Python UDF UI parameter feature split from
feat/ui-parameter.Related tracking issue / stack: #5044
Stack order:
How was this PR tested?
Manually +
Commands run:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Me