test: enable child rendering in WorkspaceComponent spec#5037
Open
Ma77Ball wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5037 +/- ##
=========================================
Coverage 42.73% 42.73%
Complexity 2191 2191
=========================================
Files 1045 1045
Lines 39979 39979
Branches 4218 4218
=========================================
Hits 17087 17087
Misses 21835 21835
Partials 1057 1057
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/request-review @mengw15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Drops the
<div #codeEditor>template stub fromWorkspaceComponent's unit spec so the realworkspace.component.htmlrenders. Heavyweight children (workflow editor, panels, menu) are kept out of the test build by strippingthe component's
imports/providersand addingCUSTOM_ELEMENTS_SCHEMA, leaving the<ng-template #codeEditor>outlet free to wire a liveViewContainerRefintoCodeEditorService.vc. A newchild rendering side effectsdescribe block asserts that the editor-lifecycle wiring runs end-to-end (the published outlet is a realViewContainerRef, proven bycreateEmbeddedViewbeing a function on it).Any related issues, documentation, or discussions?
Closes: #5015
How was this PR tested?
yarn test --include="src/app/workspace/component/workspace.component.spec.ts" --watch=false: 20/20 pass (19 prior tests preserved, 1 new).yarn test --watch=false: full suite 445 passed, 2 skipped, 2 todo (no regressions).yarn format:fix: no rewrites.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF