fix: register OneToOnePartition in PartitionInfo @JsonSubTypes#5033
Merged
Conversation
Contributor
Author
|
/request-review @Yicong-Huang |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5033 +/- ##
============================================
+ Coverage 42.79% 42.83% +0.04%
+ Complexity 2198 2195 -3
============================================
Files 1045 1031 -14
Lines 39985 38156 -1829
Branches 4217 4007 -210
============================================
- Hits 17111 16346 -765
+ Misses 21815 20791 -1024
+ Partials 1059 1019 -40
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@Yicong-Huang, thank you for the review. When available, please merge. |
Contributor
|
Thanks. I left the PR open intentionally to test the merge queue feature. Apparently it is still not functioning yet (I don't see merge queue button). Will merge this one now and we can test on other PRs (randomly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
PartitionInfo's@JsonSubTypesarray listed every concrete subclass exceptOneToOnePartition, so Jackson could not resolve that discriminator, and the round-trip was broken for any payload carrying aOneToOnePartition. This PR adds the missingnew Type(value = classOf[OneToOnePartition], name = "oneToOne")entry alongside the other five subtypes. ThePartitionInfoSpectest that pinned the (buggy) five-entry registration set, and its siblingpendingUntilFixedtest that documented the intended six-entry set, are merged into a single assertion covering all six concrete subclasses.Any related issues, documentation, or discussions?
Closes: #4805
How was this PR tested?
Updated
PartitionInfoSpecto assert the full six-entry registration set, includingOneToOnePartition.sbt scalafmtAllran clean. CI scalatest run onworkflow-coreis expected to pass.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF