fix: reset iteration cursor in OneOnEach.initialize#5028
Open
Ma77Ball wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
OneOnEach.initializenow resetsindexto0in addition to replacing theavailablearray. Previously, re-initializing an existing instance left the cursor at its prior position, causingnext()to skip elements orthrow
IndexOutOfBoundsExceptionwhen the new array was shorter than the old cursor value.Any related issues, documentation, or discussions?
Closes: #4731
How was this PR tested?
DeployStrategiesSpecso the previously-pinned "cursor survives re-initialization" test now asserts the corrected behavior (cursor reset, new array fully consumed, exhaustion still raisesIndexOutOfBoundsException).sbt "WorkflowExecutionService/testOnly ...DeployStrategiesSpec"— 13/13 pass.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF