fix: return -1 from getWorkerIndex for non-worker actor IDs

[Ma77Ball]

What changes were proposed in this PR?

VirtualIdentityUtils.getWorkerIndex only matched the worker name pattern with no fallback case, so passing a non-worker ActorVirtualIdentity (e.g. CONTROLLER, SELF) threw scala.MatchError at runtime. This PR adds a fallback case that returns -1 for non-worker actor IDs, matching the graceful handling already present in the sibling methods getPhysicalOpId and toShorterString.

Any related issues, documentation, discussions?

Closes: #4727

How was this PR tested?

Updated VirtualIdentityUtilsSpec the existing test that pinned the MatchError behavior was replaced with a test asserting that getWorkerIndex returns -1 for special actor IDs like CONTROLLER. The existing test for the worker-name happy path still passes unchanged.

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.7 in compliance with ASF

[Ma77Ball]

/request-review @Yicong-Huang

[chenlica]

@Ma77Ball Let's try to assign PRs to other committers.

@Xiao-zhen-Liu Please review it.

[Ma77Ball]

@chenlica I've also used @aicam and @kunwp1. However, I get your point. I have used @aglinxinyuan and @Yicong-Huang a lot recently. Given the large codebase, it can be hard to know who to ask for PR reviews. It would be good to either:

1. Have suggestions (automatically generated based on which parts of the codebase were edited)
2. Descriptions of each committer and which parts of the codebase they are most comfortable with (a reference for contributors to use the /request-review feature manually).

I can raise an issue if you think this is an idea the project would like to pursue.

[Yicong-Huang]

Let's not make PR triage too complicated for now. We can have auto suggestions as an improvement down the road, but for now it's easier and better to do manual triage: If a requested reviewer knows who have a better context, simply reassign.

Also, our code base is tiny, compared to other projects. You can usually do a git blame to find the owner/author of a component.

If not, feel free to request @chenlica and he can find ppl to review.

Let's not be blocked by some fancy auto triage method.

[Yicong-Huang]

In addition, I highly suggest everyone to review more PRs, even if that's not your experty. Share your thoughts, learn the code base, ask questions.

For PR authors, feel free to request more ppl to get their attention.

Descriptions of each committer and which parts of the codebase they are most comfortable with (a reference for contributors to use the /request-review feature manually).

Everyone should be comfortable review all codebase. Don't own only a file, or two. Don't be shy. I encourage everyone (not just committers) to contribute to and review everywhere.

[chenlica]

@Ma77Ball It will be easier for me to assign people to review PRs. Yes, we need more members to review PRs.

[Xiao-zhen-Liu]

LGTM with minor comments.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.33%. Comparing base (5bff1b4) to head (a1d01ae).

Files with missing lines	Patch %	Lines
...tecture/worker/managers/SerializationManager.scala	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5006      +/-   ##
============================================
+ Coverage     42.78%   43.33%   +0.54%     
+ Complexity     2197     2196       -1     
============================================
  Files          1045     1035      -10     
  Lines         39985    38856    -1129     
  Branches       4217     4064     -153     
============================================
- Hits          17109    16839     -270     
+ Misses        21818    20967     -851     
+ Partials       1058     1050       -8     

Flag	Coverage Δ		*Carryforward flag
access-control-service	39.53% <ø> (ø)
agent-service	33.72% <ø> (ø)		Carriedforward from c86dc15
amber	43.53% <78.57%> (+0.01%)	⬆️
computing-unit-managing-service	0.00% <ø> (ø)
config-service	0.00% <ø> (ø)
file-service	32.18% <ø> (ø)
frontend	34.80% <ø> (+0.75%)	⬆️	Carriedforward from c86dc15
python	88.84% <ø> (-0.06%)	⬇️	Carriedforward from c86dc15
workflow-compiling-service	47.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Ma77Ball]

@Xiao-zhen-Liu Thank you for the comments. I added the fixes.