[SYSTEMDS-3959] Report an error when a federated worker cannot bind its port - #2586
Open
gaturchenko wants to merge 1 commit into
Open
[SYSTEMDS-3959] Report an error when a federated worker cannot bind its port#2586gaturchenko wants to merge 1 commit into
gaturchenko wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
============================================
- Coverage 71.44% 71.38% -0.07%
- Complexity 50437 50550 +113
============================================
Files 1629 1633 +4
Lines 195513 196270 +757
Branches 38118 38208 +90
============================================
+ Hits 139686 140101 +415
- Misses 44867 45144 +277
- Partials 10960 11025 +65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Waiting for the review by @ywcb00 |
gaturchenko
force-pushed
the
fed-worker-invalid-port
branch
from
August 28, 2026 08:21
0612897 to
1e8037d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command
systemds WORKER 80505terminated silently with exit code 0. There are 2 causes:-w <port>, neither inbin/systemdsnor when parsing the optionFederatedWorker.run()captured every exception in a catch-all and logged onlye.getMessage(), which is empty or ambigous for a bind failure. The same held for occupied and reserved ports, and for the-fedMonitoringbackendThe following changes were implemented:
PortUtils(new): the shared range constants and validation, as well as explicit port and cause naming in case of errors;DMLOptions:-wand-fedMonitoringreject non-integers and ports outside[1, 65535]at parse time, naming the incorrect option. A missing (optional)-wargument now falls back to the default port instead of throwingNumberFormatException.FederatedWorker/FederatedMonitoringServer: a failed bind is logged throughexplainBindFailureand re-thrown asDMLRuntimeException. The monitoring backend now separatesInterruptedException(a normal shutdown) from a real failure.bin/systemds: adds a range check, a warning for reserved ports, andexit 1. Previously, an error was printed and the JVM was launched regardless.FederatedWorkerPortTest(new): 14 tests covering the range predicates, option parsing, and the two worker paths (out-of-range and occupied port).Resulting messages: