Conversation
Contributor
Code Review Agent Run #4cda76Actionable Suggestions - 0Additional Suggestions - 6
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
i18n
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44547 +/- ##
===========================================
+ Coverage 66.21% 80.93% +14.71%
===========================================
Files 2948 2949 +1
Lines 177277 177372 +95
Branches 41081 41100 +19
===========================================
+ Hits 117377 143549 +26172
+ Misses 57397 31119 -26278
- Partials 2503 2704 +201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
superset/commands/database/update.py's connection-move error message was updated to mention the SSH tunnel and OAuth2 endpoint URIs without regenerating the .pot/.po catalogs, leaving master's committed template out of sync with source and failing the babel-extract/unit-tests-required CI checks for every open PR. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rusackas
force-pushed
the
fix/regenerate-messages-pot-0922
branch
from
September 23, 2026 01:44
7572197 to
3906053
Compare
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Code Review Agent Run #c724e4Actionable Suggestions - 0Additional Suggestions - 6
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
9 tasks
6 tasks
Merged
6 tasks
Member
Author
|
#44574 already landed the same regeneration and it's on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
messages.potdrifted from source again:superset/commands/database/update.py's connection-move error message picked up mentions of the SSH tunnel and OAuth2 endpoint URIs (landed via #44003) without ababel_update.shregeneration, so the committed template no longer matches source. That failscheck_pot_drift_test.py(babel-extract,unit-tests,unit-tests-required) onmasteritself, and on every open PR whose branch includes that failure — currently blocking #44546's required checks with no relation to that PR's own diff.Ran
./scripts/translations/babel_update.shand committed the mechanical output. Pure regeneration: verified withcheck_pot_drift.py("matches a fresh extraction") and by diff — only.pot/.pofiles touched, no app code.TESTING INSTRUCTIONS
python scripts/translations/check_pot_drift.py # -> superset/translations/messages.pot matches a fresh extraction.ADDITIONAL INFORMATION
🤖 Generated with Claude Code